Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better NODE_ENV explanation #13476

Merged
merged 2 commits into from
May 28, 2020
Merged

Better NODE_ENV explanation #13476

merged 2 commits into from
May 28, 2020

Conversation

Timer
Copy link
Member

@Timer Timer commented May 28, 2020

After #12361, I've seen a few users ask "but why".

This PR updates the err.sh link to better explain the restriction.

It also provides an alternative!

@Timer Timer added this to the 9.4.4 milestone May 28, 2020
@Timer Timer requested review from ijjk, lfades and timneutkens as code owners May 28, 2020 03:18
@kodiakhq kodiakhq bot merged commit aab1fff into vercel:canary May 28, 2020
@Timer Timer deleted the docs/node_env branch May 28, 2020 11:49
@vvo
Copy link
Member

vvo commented May 28, 2020

This is great, I have been advocating for the use of APP_ENV too, to differentiate from NODE_ENV. Thanks!

rokinsky pushed a commit to rokinsky/next.js that referenced this pull request Jul 11, 2020
After vercel#12361, I've seen a few users ask "but why".

This PR updates the err.sh link to better explain the restriction.

It also provides an alternative!
@vercel vercel locked as resolved and limited conversation to collaborators Jan 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants