Add warning when viewport meta tag is added to _document.js #13452

TyMick · 2020-05-27T16:45:35Z

Resolves #13230, where multiple viewport meta tags were showing up on the page when one was added to _document.js. This adds a warning similar to the existing warning for using <title> in _document.js, since the viewport is supposed to be handled by next/head.

I was thinking, while I'm at it, of adding warnings for all of the <head> elements that should only be handled by next/head. Would those be the element types that head.tsx's unique() function checks to filter out duplicates? That is,

<title>
<base>
<meta name=...
<meta httpEquiv=...
<meta charSet=...
<meta itemProp=...

ijjk · 2020-05-27T16:53:41Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall increase ⚠️

	zeit/next.js canary	tywmick/next.js meta-viewport-document-warning	Change
buildDuration	12.2s	12.3s	⚠️ +122ms
nodeModulesSize	67.3 MB	67.3 MB	⚠️ +934 B

Page Load Tests Overall increase ✓

	zeit/next.js canary	tywmick/next.js meta-viewport-document-warning	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.109	2.067	-0.04
/ avg req/sec	1185.61	1209.35	⚠️ +23.74
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.137	1.145	⚠️ +0.01
/error-in-render avg req/sec	2198.22	2183.12	-15.1

Client Bundles (main, webpack, commons)

	zeit/next.js canary	tywmick/next.js meta-viewport-document-warning	Change
main-HASH.js gzip	6.59 kB	6.59 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..c03c.js gzip	10.5 kB	10.5 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	57 kB	57 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	tywmick/next.js meta-viewport-document-warning	Change
main-HASH.module.js gzip	5.67 kB	5.67 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.92 kB	6.92 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	52.5 kB	52.5 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	tywmick/next.js meta-viewport-document-warning	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	zeit/next.js canary	tywmick/next.js meta-viewport-document-warning	Change
_app.js gzip	1.26 kB	1.26 kB	✓
_error.js gzip	3.25 kB	3.25 kB	✓
hooks.js gzip	881 B	881 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.06 kB	2.06 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	8.22 kB	8.22 kB	✓

Client Pages Modern

	zeit/next.js canary	tywmick/next.js meta-viewport-document-warning	Change
_app.module.js gzip	604 B	604 B	✓
_error.module.js gzip	2.04 kB	2.04 kB	✓
hooks.module.js gzip	383 B	383 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js gzip	1.52 kB	1.52 kB	✓
routerDirect..dule.js gzip	281 B	281 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
Overall change	5.33 kB	5.33 kB	✓

Client Build Manifests

	zeit/next.js canary	tywmick/next.js meta-viewport-document-warning	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Rendered Page Sizes

	zeit/next.js canary	tywmick/next.js meta-viewport-document-warning	Change
index.html gzip	927 B	927 B	✓
link.html gzip	936 B	936 B	✓
withRouter.html gzip	925 B	925 B	✓
Overall change	2.79 kB	2.79 kB	✓

Serverless Mode

General Overall increase ⚠️

	zeit/next.js canary	tywmick/next.js meta-viewport-document-warning	Change
buildDuration	13.2s	13s	-160ms
nodeModulesSize	67.3 MB	67.3 MB	⚠️ +934 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	tywmick/next.js meta-viewport-document-warning	Change
main-HASH.js gzip	6.59 kB	6.59 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..c03c.js gzip	10.5 kB	10.5 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	57 kB	57 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	tywmick/next.js meta-viewport-document-warning	Change
main-HASH.module.js gzip	5.67 kB	5.67 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.92 kB	6.92 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	52.5 kB	52.5 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	tywmick/next.js meta-viewport-document-warning	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	zeit/next.js canary	tywmick/next.js meta-viewport-document-warning	Change
_app.js gzip	1.26 kB	1.26 kB	✓
_error.js gzip	3.25 kB	3.25 kB	✓
hooks.js gzip	881 B	881 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.06 kB	2.06 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	8.22 kB	8.22 kB	✓

Client Pages Modern

	zeit/next.js canary	tywmick/next.js meta-viewport-document-warning	Change
_app.module.js gzip	604 B	604 B	✓
_error.module.js gzip	2.04 kB	2.04 kB	✓
hooks.module.js gzip	383 B	383 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js gzip	1.52 kB	1.52 kB	✓
routerDirect..dule.js gzip	281 B	281 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
Overall change	5.33 kB	5.33 kB	✓

Client Build Manifests

	zeit/next.js canary	tywmick/next.js meta-viewport-document-warning	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Serverless bundles

	zeit/next.js canary	tywmick/next.js meta-viewport-document-warning	Change
_error.js	876 kB	876 kB	✓
404.html	4.18 kB	4.18 kB	✓
hooks.html	3.81 kB	3.81 kB	✓
index.js	877 kB	877 kB	✓
link.js	914 kB	914 kB	✓
routerDirect.js	907 kB	907 kB	✓
withRouter.js	907 kB	907 kB	✓
Overall change	4.49 MB	4.49 MB	✓

errors/no-document-viewport-meta.md

TyMick · 2020-05-28T16:05:26Z

@Timer Thanks! Should I get rid of the commented-out getInitialProps that's included on the docs page, or leave it in?

Also updated the no-document-title error's custom app code while I was at it.

Timer

Yeah, let's drop it for tersity.

errors/no-document-title.md

errors/no-document-viewport-meta.md

Timer

We need to test this behavior so there's no regression.

TyMick · 2020-05-29T15:50:38Z

@Timer I'm still new to testing—are you meaning the chromedriver tests or testing a local app that has a viewport meta tag in its _document.js to make sure the warning shows up correctly? And what's "regression" in this context?

Thanks for your patience!

TyMick · 2020-06-05T17:56:21Z

@Timer After #13560 I think I understand well enough how the tests work now. 👌🏼 I'm putting one together.

TyMick · 2020-06-05T20:53:38Z

Added a new test suite for all three document/head warnings: <title>, viewport meta tags, and the crossOrigin attribute. That cover it?

ijjk · 2020-06-05T21:01:45Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall increase ⚠️

	zeit/next.js canary	tywmick/next.js meta-viewport-document-warning	Change
buildDuration	13s	12.3s	-678ms
nodeModulesSize	66 MB	66 MB	⚠️ +934 B

Page Load Tests Overall increase ✓

	zeit/next.js canary	tywmick/next.js meta-viewport-document-warning	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.227	2.206	-0.02
/ avg req/sec	1122.36	1133.15	⚠️ +10.79
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.415	1.414	0
/error-in-render avg req/sec	1766.5	1768.04	⚠️ +1.54

Client Bundles (main, webpack, commons)

	zeit/next.js canary	tywmick/next.js meta-viewport-document-warning	Change
main-HASH.js gzip	6.61 kB	6.61 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..9545.js gzip	10.5 kB	10.5 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	57 kB	57 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	tywmick/next.js meta-viewport-document-warning	Change
main-HASH.module.js gzip	5.69 kB	5.69 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.92 kB	6.92 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	52.5 kB	52.5 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	tywmick/next.js meta-viewport-document-warning	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	zeit/next.js canary	tywmick/next.js meta-viewport-document-warning	Change
_app.js gzip	1.26 kB	1.26 kB	✓
_error.js gzip	3.25 kB	3.25 kB	✓
hooks.js gzip	881 B	881 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.05 kB	2.05 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	8.21 kB	8.21 kB	✓

Client Pages Modern

	zeit/next.js canary	tywmick/next.js meta-viewport-document-warning	Change
_app.module.js gzip	604 B	604 B	✓
_error.module.js gzip	2.04 kB	2.04 kB	✓
hooks.module.js gzip	383 B	383 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js gzip	1.51 kB	1.51 kB	✓
routerDirect..dule.js gzip	281 B	281 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
Overall change	5.32 kB	5.32 kB	✓

Client Build Manifests

	zeit/next.js canary	tywmick/next.js meta-viewport-document-warning	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Rendered Page Sizes

	zeit/next.js canary	tywmick/next.js meta-viewport-document-warning	Change
index.html gzip	927 B	927 B	✓
link.html gzip	936 B	936 B	✓
withRouter.html gzip	924 B	924 B	✓
Overall change	2.79 kB	2.79 kB	✓

Serverless Mode

General Overall increase ⚠️

	zeit/next.js canary	tywmick/next.js meta-viewport-document-warning	Change
buildDuration	13.6s	14.5s	⚠️ +954ms
nodeModulesSize	66 MB	66 MB	⚠️ +934 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	tywmick/next.js meta-viewport-document-warning	Change
main-HASH.js gzip	6.61 kB	6.61 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..9545.js gzip	10.5 kB	10.5 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	57 kB	57 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	tywmick/next.js meta-viewport-document-warning	Change
main-HASH.module.js gzip	5.69 kB	5.69 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.92 kB	6.92 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	52.5 kB	52.5 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	tywmick/next.js meta-viewport-document-warning	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	zeit/next.js canary	tywmick/next.js meta-viewport-document-warning	Change
_app.js gzip	1.26 kB	1.26 kB	✓
_error.js gzip	3.25 kB	3.25 kB	✓
hooks.js gzip	881 B	881 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.05 kB	2.05 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	8.21 kB	8.21 kB	✓

Client Pages Modern

	zeit/next.js canary	tywmick/next.js meta-viewport-document-warning	Change
_app.module.js gzip	604 B	604 B	✓
_error.module.js gzip	2.04 kB	2.04 kB	✓
hooks.module.js gzip	383 B	383 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js gzip	1.51 kB	1.51 kB	✓
routerDirect..dule.js gzip	281 B	281 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
Overall change	5.32 kB	5.32 kB	✓

Client Build Manifests

	zeit/next.js canary	tywmick/next.js meta-viewport-document-warning	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Serverless bundles

	zeit/next.js canary	tywmick/next.js meta-viewport-document-warning	Change
_error.js	878 kB	878 kB	✓
404.html	4.18 kB	4.18 kB	✓
hooks.html	3.81 kB	3.81 kB	✓
index.js	878 kB	878 kB	✓
link.js	916 kB	916 kB	✓
routerDirect.js	909 kB	909 kB	✓
withRouter.js	909 kB	909 kB	✓
Overall change	4.5 MB	4.5 MB	✓

timneutkens

Looks great! Thanks @tywmick 🙏

ijjk · 2020-07-07T05:16:18Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	tywmick/next.js meta-viewport-document-warning	Change
buildDuration	13.3s	13.2s	-44ms
nodeModulesSize	66.1 MB	66.1 MB	⚠️ +937 B

Page Load Tests Overall increase ✓

	vercel/next.js canary	tywmick/next.js meta-viewport-document-warning	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.262	2.222	-0.04
/ avg req/sec	1105.22	1124.92	+19.7
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.596	1.49	-0.11
/error-in-render avg req/sec	1566.38	1677.78	+111.4

Client Bundles (main, webpack, commons)

	vercel/next.js canary	tywmick/next.js meta-viewport-document-warning	Change
main-HASH.js gzip	6.63 kB	6.63 kB	✓
webpack-HASH.js gzip	751 B	751 B	✓
19b7e98f51cc..6834.js gzip	10.7 kB	10.7 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	57.2 kB	57.2 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	tywmick/next.js meta-viewport-document-warning	Change
main-HASH.module.js gzip	5.71 kB	5.71 kB	✓
webpack-HASH..dule.js gzip	751 B	751 B	✓
19b7e98f51cc..dule.js gzip	7.09 kB	7.09 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	52.7 kB	52.7 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	tywmick/next.js meta-viewport-document-warning	Change
polyfills-HASH.js gzip	26.4 kB	26.4 kB	✓
Overall change	26.4 kB	26.4 kB	✓

Client Build Manifests

	vercel/next.js canary	tywmick/next.js meta-viewport-document-warning	Change
_buildManifest.js gzip	268 B	268 B	✓
_buildManife..dule.js gzip	272 B	272 B	✓
Overall change	540 B	540 B	✓

Rendered Page Sizes

	vercel/next.js canary	tywmick/next.js meta-viewport-document-warning	Change
index.html gzip	953 B	953 B	✓
link.html gzip	960 B	960 B	✓
withRouter.html gzip	945 B	945 B	✓
Overall change	2.86 kB	2.86 kB	✓

Serverless Mode

General Overall increase ⚠️

	vercel/next.js canary	tywmick/next.js meta-viewport-document-warning	Change
buildDuration	13.5s	13.7s	⚠️ +189ms
nodeModulesSize	66.1 MB	66.1 MB	⚠️ +937 B

Client Bundles (main, webpack, commons)

	vercel/next.js canary	tywmick/next.js meta-viewport-document-warning	Change
main-HASH.js gzip	6.63 kB	6.63 kB	✓
webpack-HASH.js gzip	751 B	751 B	✓
19b7e98f51cc..6834.js gzip	10.7 kB	10.7 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	57.2 kB	57.2 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	tywmick/next.js meta-viewport-document-warning	Change
main-HASH.module.js gzip	5.71 kB	5.71 kB	✓
webpack-HASH..dule.js gzip	751 B	751 B	✓
19b7e98f51cc..dule.js gzip	7.09 kB	7.09 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	52.7 kB	52.7 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	tywmick/next.js meta-viewport-document-warning	Change
polyfills-HASH.js gzip	26.4 kB	26.4 kB	✓
Overall change	26.4 kB	26.4 kB	✓

Client Build Manifests

	vercel/next.js canary	tywmick/next.js meta-viewport-document-warning	Change
_buildManifest.js gzip	268 B	268 B	✓
_buildManife..dule.js gzip	272 B	272 B	✓
Overall change	540 B	540 B	✓

Serverless bundles

	vercel/next.js canary	tywmick/next.js meta-viewport-document-warning	Change
_error.js	876 kB	876 kB	✓
404.html	4.17 kB	4.17 kB	✓
hooks.html	3.79 kB	3.79 kB	✓
index.js	877 kB	877 kB	✓
link.js	915 kB	915 kB	✓
routerDirect.js	909 kB	909 kB	✓
withRouter.js	909 kB	909 kB	✓
Overall change	4.49 MB	4.49 MB	✓

Commit: a497b98

ijjk · 2020-07-07T05:33:42Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General Overall increase ⚠️

	vercel/next.js canary	tywmick/next.js meta-viewport-document-warning	Change
buildDuration	12.8s	12.4s	-379ms
nodeModulesSize	66.1 MB	66.1 MB	⚠️ +937 B

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	tywmick/next.js meta-viewport-document-warning	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.092	2.076	-0.02
/ avg req/sec	1195.09	1204.44	+9.35
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.222	1.263	⚠️ +0.04
/error-in-render avg req/sec	2046.28	1979.22	⚠️ -67.06

Client Bundles (main, webpack, commons)

	vercel/next.js canary	tywmick/next.js meta-viewport-document-warning	Change
main-HASH.js gzip	6.63 kB	6.63 kB	✓
webpack-HASH.js gzip	751 B	751 B	✓
19b7e98f51cc..c646.js gzip	10.7 kB	10.7 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	57.2 kB	57.2 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	tywmick/next.js meta-viewport-document-warning	Change
main-HASH.module.js gzip	5.71 kB	5.71 kB	✓
webpack-HASH..dule.js gzip	751 B	751 B	✓
19b7e98f51cc..dule.js gzip	7.1 kB	7.1 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	52.7 kB	52.7 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	tywmick/next.js meta-viewport-document-warning	Change
polyfills-HASH.js gzip	26.4 kB	26.4 kB	✓
Overall change	26.4 kB	26.4 kB	✓

Client Build Manifests

	vercel/next.js canary	tywmick/next.js meta-viewport-document-warning	Change
_buildManifest.js gzip	268 B	268 B	✓
_buildManife..dule.js gzip	272 B	272 B	✓
Overall change	540 B	540 B	✓

Rendered Page Sizes

	vercel/next.js canary	tywmick/next.js meta-viewport-document-warning	Change
index.html gzip	954 B	954 B	✓
link.html gzip	960 B	960 B	✓
withRouter.html gzip	945 B	945 B	✓
Overall change	2.86 kB	2.86 kB	✓

Serverless Mode

General Overall increase ⚠️

	vercel/next.js canary	tywmick/next.js meta-viewport-document-warning	Change
buildDuration	13.2s	13.4s	⚠️ +243ms
nodeModulesSize	66.1 MB	66.1 MB	⚠️ +937 B

Client Bundles (main, webpack, commons)

	vercel/next.js canary	tywmick/next.js meta-viewport-document-warning	Change
main-HASH.js gzip	6.63 kB	6.63 kB	✓
webpack-HASH.js gzip	751 B	751 B	✓
19b7e98f51cc..c646.js gzip	10.7 kB	10.7 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	57.2 kB	57.2 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	tywmick/next.js meta-viewport-document-warning	Change
main-HASH.module.js gzip	5.71 kB	5.71 kB	✓
webpack-HASH..dule.js gzip	751 B	751 B	✓
19b7e98f51cc..dule.js gzip	7.1 kB	7.1 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	52.7 kB	52.7 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	tywmick/next.js meta-viewport-document-warning	Change
polyfills-HASH.js gzip	26.4 kB	26.4 kB	✓
Overall change	26.4 kB	26.4 kB	✓

Client Build Manifests

	vercel/next.js canary	tywmick/next.js meta-viewport-document-warning	Change
_buildManifest.js gzip	268 B	268 B	✓
_buildManife..dule.js gzip	272 B	272 B	✓
Overall change	540 B	540 B	✓

Serverless bundles

	vercel/next.js canary	tywmick/next.js meta-viewport-document-warning	Change
_error.js	876 kB	876 kB	✓
404.html	4.17 kB	4.17 kB	✓
hooks.html	3.79 kB	3.79 kB	✓
index.js	877 kB	877 kB	✓
link.js	915 kB	915 kB	✓
routerDirect.js	909 kB	909 kB	✓
withRouter.js	909 kB	909 kB	✓
Overall change	4.49 MB	4.49 MB	✓

Commit: 36d164a

ijjk · 2020-07-07T05:34:22Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	tywmick/next.js meta-viewport-document-warning	Change
buildDuration	13.2s	13.4s	⚠️ +255ms
nodeModulesSize	66.1 MB	66.1 MB	⚠️ +937 B

Page Load Tests Overall increase ✓

	vercel/next.js canary	tywmick/next.js meta-viewport-document-warning	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.368	2.33	-0.04
/ avg req/sec	1055.82	1072.87	+17.05
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.462	1.447	-0.01
/error-in-render avg req/sec	1709.57	1727.56	+17.99

Client Bundles (main, webpack, commons)

	vercel/next.js canary	tywmick/next.js meta-viewport-document-warning	Change
main-HASH.js gzip	6.63 kB	6.63 kB	✓
webpack-HASH.js gzip	751 B	751 B	✓
19b7e98f51cc..c646.js gzip	10.7 kB	10.7 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	57.2 kB	57.2 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	tywmick/next.js meta-viewport-document-warning	Change
main-HASH.module.js gzip	5.71 kB	5.71 kB	✓
webpack-HASH..dule.js gzip	751 B	751 B	✓
19b7e98f51cc..dule.js gzip	7.1 kB	7.1 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	52.7 kB	52.7 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	tywmick/next.js meta-viewport-document-warning	Change
polyfills-HASH.js gzip	26.4 kB	26.4 kB	✓
Overall change	26.4 kB	26.4 kB	✓

Client Build Manifests

	vercel/next.js canary	tywmick/next.js meta-viewport-document-warning	Change
_buildManifest.js gzip	268 B	268 B	✓
_buildManife..dule.js gzip	272 B	272 B	✓
Overall change	540 B	540 B	✓

Rendered Page Sizes

	vercel/next.js canary	tywmick/next.js meta-viewport-document-warning	Change
index.html gzip	954 B	954 B	✓
link.html gzip	960 B	960 B	✓
withRouter.html gzip	945 B	945 B	✓
Overall change	2.86 kB	2.86 kB	✓

Serverless Mode

General Overall increase ⚠️

	vercel/next.js canary	tywmick/next.js meta-viewport-document-warning	Change
buildDuration	14.4s	14.7s	⚠️ +364ms
nodeModulesSize	66.1 MB	66.1 MB	⚠️ +937 B

Client Bundles (main, webpack, commons)

	vercel/next.js canary	tywmick/next.js meta-viewport-document-warning	Change
main-HASH.js gzip	6.63 kB	6.63 kB	✓
webpack-HASH.js gzip	751 B	751 B	✓
19b7e98f51cc..c646.js gzip	10.7 kB	10.7 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	57.2 kB	57.2 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	tywmick/next.js meta-viewport-document-warning	Change
main-HASH.module.js gzip	5.71 kB	5.71 kB	✓
webpack-HASH..dule.js gzip	751 B	751 B	✓
19b7e98f51cc..dule.js gzip	7.1 kB	7.1 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	52.7 kB	52.7 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	tywmick/next.js meta-viewport-document-warning	Change
polyfills-HASH.js gzip	26.4 kB	26.4 kB	✓
Overall change	26.4 kB	26.4 kB	✓

Client Build Manifests

	vercel/next.js canary	tywmick/next.js meta-viewport-document-warning	Change
_buildManifest.js gzip	268 B	268 B	✓
_buildManife..dule.js gzip	272 B	272 B	✓
Overall change	540 B	540 B	✓

Serverless bundles

	vercel/next.js canary	tywmick/next.js meta-viewport-document-warning	Change
_error.js	876 kB	876 kB	✓
404.html	4.17 kB	4.17 kB	✓
hooks.html	3.79 kB	3.79 kB	✓
index.js	877 kB	877 kB	✓
link.js	915 kB	915 kB	✓
routerDirect.js	909 kB	909 kB	✓
withRouter.js	909 kB	909 kB	✓
Overall change	4.49 MB	4.49 MB	✓

Commit: 36d164a

…3452) Co-authored-by: Joe Haddad <[email protected]> Co-authored-by: Joe Haddad <[email protected]>

TyMick added 2 commits May 27, 2020 12:10

Add initial warning

86066bd

Add no-document-viewport-meta error page

9e94b13

TyMick requested review from ijjk, lfades, Timer and timneutkens as code owners May 27, 2020 16:45

Timer reviewed May 28, 2020

View reviewed changes

errors/no-document-viewport-meta.md Outdated Show resolved Hide resolved

TyMick added 2 commits May 28, 2020 11:59

Update code snippet to modern custom app design

b32b3ab

Update "no document title" error to modern _app

af0e5a1

Timer requested changes May 28, 2020

View reviewed changes

errors/no-document-title.md Outdated Show resolved Hide resolved

errors/no-document-viewport-meta.md Outdated Show resolved Hide resolved

errors/no-document-viewport-meta.md Outdated Show resolved Hide resolved

Timer self-assigned this May 28, 2020

Apply suggestions from code review

57706c3

Timer requested changes May 28, 2020

View reviewed changes

Add test suite for document/head warnings

1893f3d

ijjk added type: documentation type: next labels Jun 5, 2020

timneutkens approved these changes Jul 4, 2020

View reviewed changes

Timer approved these changes Jul 7, 2020

View reviewed changes

Merge branch 'canary' into meta-viewport-document-warning

a497b98

Merge branch 'canary' into meta-viewport-document-warning

36d164a

Timer merged commit 1f5bbb3 into vercel:canary Jul 7, 2020

rokinsky pushed a commit to rokinsky/next.js that referenced this pull request Jul 11, 2020

Add warning when viewport meta tag is added to _document.js (vercel#1…

81254d1

…3452) Co-authored-by: Joe Haddad <[email protected]> Co-authored-by: Joe Haddad <[email protected]>

vercel locked as resolved and limited conversation to collaborators Jan 30, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add warning when viewport meta tag is added to _document.js #13452

Add warning when viewport meta tag is added to _document.js #13452

TyMick commented May 27, 2020

ijjk commented May 27, 2020

TyMick commented May 28, 2020

Timer left a comment

Timer left a comment

TyMick commented May 29, 2020

TyMick commented Jun 5, 2020

TyMick commented Jun 5, 2020

ijjk commented Jun 5, 2020

timneutkens left a comment

ijjk commented Jul 7, 2020

ijjk commented Jul 7, 2020

ijjk commented Jul 7, 2020

Add warning when viewport meta tag is added to _document.js #13452

Add warning when viewport meta tag is added to _document.js #13452

Conversation

TyMick commented May 27, 2020

ijjk commented May 27, 2020

Stats from current PR

TyMick commented May 28, 2020

Timer left a comment

Choose a reason for hiding this comment

Timer left a comment

Choose a reason for hiding this comment

TyMick commented May 29, 2020

TyMick commented Jun 5, 2020

TyMick commented Jun 5, 2020

ijjk commented Jun 5, 2020

Stats from current PR

timneutkens left a comment

Choose a reason for hiding this comment

ijjk commented Jul 7, 2020

Stats from current PR

ijjk commented Jul 7, 2020

Stats from current PR

ijjk commented Jul 7, 2020

Stats from current PR