Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Remove some redundant imports #13066

Merged
merged 4 commits into from
May 20, 2020
Merged

chore: Remove some redundant imports #13066

merged 4 commits into from
May 20, 2020

Conversation

teo-garcia
Copy link
Contributor

This issue is related to 12694. I covered the following examples

  • with-zeit-fetch
  • with-yarn-workspaces
  • with-why-did-your-render
  • with-video-js
  • with-universal-configuration-runtime
  • with-typestyle
  • with-three-js

If you have a suggestion or change I'd appreciate it

@teo-garcia teo-garcia requested review from lfades and Timer as code owners May 18, 2020 20:52
@ijjk
Copy link
Member

ijjk commented May 18, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
zeit/next.js canary jmgr2996/next.js feat/remove-some-react-unnecesary-imports Change
buildDuration 11.9s 12.5s ⚠️ +574ms
nodeModulesSize 60.4 MB 60.4 MB ✓
Page Load Tests Overall decrease ⚠️
zeit/next.js canary jmgr2996/next.js feat/remove-some-react-unnecesary-imports Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.024 1.96 -0.06
/ avg req/sec 1235.21 1275.48 ⚠️ +40.27
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.126 1.152 ⚠️ +0.03
/error-in-render avg req/sec 2219.6 2170.49 -49.11
Client Bundles (main, webpack, commons)
zeit/next.js canary jmgr2996/next.js feat/remove-some-react-unnecesary-imports Change
main-HASH.js gzip 6.71 kB 6.71 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..fc14.js gzip 10.5 kB 10.5 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 57.1 kB 57.1 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary jmgr2996/next.js feat/remove-some-react-unnecesary-imports Change
main-HASH.module.js gzip 5.74 kB 5.74 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.88 kB 6.88 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.5 kB 52.5 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary jmgr2996/next.js feat/remove-some-react-unnecesary-imports Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary jmgr2996/next.js feat/remove-some-react-unnecesary-imports Change
_app.js gzip 1.26 kB 1.26 kB ✓
_error.js gzip 3.28 kB 3.28 kB ✓
hooks.js gzip 881 B 881 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.06 kB 2.06 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 8.26 kB 8.26 kB ✓
Client Pages Modern
zeit/next.js canary jmgr2996/next.js feat/remove-some-react-unnecesary-imports Change
_app.module.js gzip 604 B 604 B ✓
_error.module.js gzip 2.09 kB 2.09 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.38 kB 5.38 kB ✓
Client Build Manifests
zeit/next.js canary jmgr2996/next.js feat/remove-some-react-unnecesary-imports Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
zeit/next.js canary jmgr2996/next.js feat/remove-some-react-unnecesary-imports Change
index.html gzip 926 B 926 B ✓
link.html gzip 936 B 936 B ✓
withRouter.html gzip 923 B 923 B ✓
Overall change 2.79 kB 2.79 kB ✓
Serverless Mode
General
zeit/next.js canary jmgr2996/next.js feat/remove-some-react-unnecesary-imports Change
buildDuration 12.8s 13s ⚠️ +198ms
nodeModulesSize 60.4 MB 60.4 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary jmgr2996/next.js feat/remove-some-react-unnecesary-imports Change
main-HASH.js gzip 6.71 kB 6.71 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..fc14.js gzip 10.5 kB 10.5 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 57.1 kB 57.1 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary jmgr2996/next.js feat/remove-some-react-unnecesary-imports Change
main-HASH.module.js gzip 5.74 kB 5.74 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.88 kB 6.88 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.5 kB 52.5 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary jmgr2996/next.js feat/remove-some-react-unnecesary-imports Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary jmgr2996/next.js feat/remove-some-react-unnecesary-imports Change
_app.js gzip 1.26 kB 1.26 kB ✓
_error.js gzip 3.28 kB 3.28 kB ✓
hooks.js gzip 881 B 881 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.06 kB 2.06 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 8.26 kB 8.26 kB ✓
Client Pages Modern
zeit/next.js canary jmgr2996/next.js feat/remove-some-react-unnecesary-imports Change
_app.module.js gzip 604 B 604 B ✓
_error.module.js gzip 2.09 kB 2.09 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.38 kB 5.38 kB ✓
Client Build Manifests
zeit/next.js canary jmgr2996/next.js feat/remove-some-react-unnecesary-imports Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles
zeit/next.js canary jmgr2996/next.js feat/remove-some-react-unnecesary-imports Change
_error.js 851 kB 851 kB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.81 kB 3.81 kB ✓
index.js 851 kB 851 kB ✓
link.js 888 kB 888 kB ✓
routerDirect.js 880 kB 880 kB ✓
withRouter.js 881 kB 881 kB ✓
Overall change 4.36 MB 4.36 MB ✓

@Timer Timer added this to the 9.4.2 milestone May 20, 2020
@Timer Timer added the examples Issue was opened via the examples template. label May 20, 2020
Timer
Timer approved these changes May 20, 2020
View reviewed changes
Copy link
Member

@Timer Timer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ijjk
Copy link
Member

ijjk commented May 20, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
zeit/next.js canary jmgr2996/next.js feat/remove-some-react-unnecesary-imports Change
buildDuration 11.4s 11.5s ⚠️ +167ms
nodeModulesSize 61.8 MB 61.8 MB ✓
Page Load Tests Overall decrease ⚠️
zeit/next.js canary jmgr2996/next.js feat/remove-some-react-unnecesary-imports Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.981 2.012 ⚠️ +0.03
/ avg req/sec 1262.03 1242.61 -19.42
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.258 1.307 ⚠️ +0.05
/error-in-render avg req/sec 1988.06 1912.06 -76
Client Bundles (main, webpack, commons)
zeit/next.js canary jmgr2996/next.js feat/remove-some-react-unnecesary-imports Change
main-HASH.js gzip 6.65 kB 6.65 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..fef6.js gzip 10.5 kB 10.5 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 57 kB 57 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary jmgr2996/next.js feat/remove-some-react-unnecesary-imports Change
main-HASH.module.js gzip 5.69 kB 5.69 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.92 kB 6.92 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.5 kB 52.5 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary jmgr2996/next.js feat/remove-some-react-unnecesary-imports Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary jmgr2996/next.js feat/remove-some-react-unnecesary-imports Change
_app.js gzip 1.26 kB 1.26 kB ✓
_error.js gzip 3.25 kB 3.25 kB ✓
hooks.js gzip 881 B 881 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.06 kB 2.06 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 8.22 kB 8.22 kB ✓
Client Pages Modern
zeit/next.js canary jmgr2996/next.js feat/remove-some-react-unnecesary-imports Change
_app.module.js gzip 604 B 604 B ✓
_error.module.js gzip 2.04 kB 2.04 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.33 kB 5.33 kB ✓
Client Build Manifests
zeit/next.js canary jmgr2996/next.js feat/remove-some-react-unnecesary-imports Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
zeit/next.js canary jmgr2996/next.js feat/remove-some-react-unnecesary-imports Change
index.html gzip 928 B 928 B ✓
link.html gzip 938 B 938 B ✓
withRouter.html gzip 925 B 925 B ✓
Overall change 2.79 kB 2.79 kB ✓
Serverless Mode
General
zeit/next.js canary jmgr2996/next.js feat/remove-some-react-unnecesary-imports Change
buildDuration 12.2s 12.3s ⚠️ +118ms
nodeModulesSize 61.8 MB 61.8 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary jmgr2996/next.js feat/remove-some-react-unnecesary-imports Change
main-HASH.js gzip 6.65 kB 6.65 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..fef6.js gzip 10.5 kB 10.5 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 57 kB 57 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary jmgr2996/next.js feat/remove-some-react-unnecesary-imports Change
main-HASH.module.js gzip 5.69 kB 5.69 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.92 kB 6.92 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.5 kB 52.5 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary jmgr2996/next.js feat/remove-some-react-unnecesary-imports Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary jmgr2996/next.js feat/remove-some-react-unnecesary-imports Change
_app.js gzip 1.26 kB 1.26 kB ✓
_error.js gzip 3.25 kB 3.25 kB ✓
hooks.js gzip 881 B 881 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.06 kB 2.06 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 8.22 kB 8.22 kB ✓
Client Pages Modern
zeit/next.js canary jmgr2996/next.js feat/remove-some-react-unnecesary-imports Change
_app.module.js gzip 604 B 604 B ✓
_error.module.js gzip 2.04 kB 2.04 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.33 kB 5.33 kB ✓
Client Build Manifests
zeit/next.js canary jmgr2996/next.js feat/remove-some-react-unnecesary-imports Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles
zeit/next.js canary jmgr2996/next.js feat/remove-some-react-unnecesary-imports Change
_error.js 844 kB 844 kB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.81 kB 3.81 kB ✓
index.js 844 kB 844 kB ✓
link.js 882 kB 882 kB ✓
routerDirect.js 874 kB 874 kB ✓
withRouter.js 874 kB 874 kB ✓
Overall change 4.33 MB 4.33 MB ✓

@ijjk
Copy link
Member

ijjk commented May 20, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
zeit/next.js canary jmgr2996/next.js feat/remove-some-react-unnecesary-imports Change
buildDuration 11.9s 12.3s ⚠️ +393ms
nodeModulesSize 61.8 MB 61.8 MB ✓
Page Load Tests Overall decrease ⚠️
zeit/next.js canary jmgr2996/next.js feat/remove-some-react-unnecesary-imports Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.996 1.999 0
/ avg req/sec 1252.61 1250.6 -2.01
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.155 1.209 ⚠️ +0.05
/error-in-render avg req/sec 2165.19 2067.44 -97.75
Client Bundles (main, webpack, commons)
zeit/next.js canary jmgr2996/next.js feat/remove-some-react-unnecesary-imports Change
main-HASH.js gzip 6.65 kB 6.65 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..fef6.js gzip 10.5 kB 10.5 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 57 kB 57 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary jmgr2996/next.js feat/remove-some-react-unnecesary-imports Change
main-HASH.module.js gzip 5.69 kB 5.69 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.92 kB 6.92 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.5 kB 52.5 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary jmgr2996/next.js feat/remove-some-react-unnecesary-imports Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary jmgr2996/next.js feat/remove-some-react-unnecesary-imports Change
_app.js gzip 1.26 kB 1.26 kB ✓
_error.js gzip 3.25 kB 3.25 kB ✓
hooks.js gzip 881 B 881 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.06 kB 2.06 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 8.22 kB 8.22 kB ✓
Client Pages Modern
zeit/next.js canary jmgr2996/next.js feat/remove-some-react-unnecesary-imports Change
_app.module.js gzip 604 B 604 B ✓
_error.module.js gzip 2.04 kB 2.04 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.33 kB 5.33 kB ✓
Client Build Manifests
zeit/next.js canary jmgr2996/next.js feat/remove-some-react-unnecesary-imports Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
zeit/next.js canary jmgr2996/next.js feat/remove-some-react-unnecesary-imports Change
index.html gzip 928 B 928 B ✓
link.html gzip 938 B 938 B ✓
withRouter.html gzip 925 B 925 B ✓
Overall change 2.79 kB 2.79 kB ✓
Serverless Mode
General
zeit/next.js canary jmgr2996/next.js feat/remove-some-react-unnecesary-imports Change
buildDuration 13.1s 12.9s -162ms
nodeModulesSize 61.8 MB 61.8 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary jmgr2996/next.js feat/remove-some-react-unnecesary-imports Change
main-HASH.js gzip 6.65 kB 6.65 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..fef6.js gzip 10.5 kB 10.5 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 57 kB 57 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary jmgr2996/next.js feat/remove-some-react-unnecesary-imports Change
main-HASH.module.js gzip 5.69 kB 5.69 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.92 kB 6.92 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.5 kB 52.5 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary jmgr2996/next.js feat/remove-some-react-unnecesary-imports Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary jmgr2996/next.js feat/remove-some-react-unnecesary-imports Change
_app.js gzip 1.26 kB 1.26 kB ✓
_error.js gzip 3.25 kB 3.25 kB ✓
hooks.js gzip 881 B 881 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.06 kB 2.06 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 8.22 kB 8.22 kB ✓
Client Pages Modern
zeit/next.js canary jmgr2996/next.js feat/remove-some-react-unnecesary-imports Change
_app.module.js gzip 604 B 604 B ✓
_error.module.js gzip 2.04 kB 2.04 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.33 kB 5.33 kB ✓
Client Build Manifests
zeit/next.js canary jmgr2996/next.js feat/remove-some-react-unnecesary-imports Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles
zeit/next.js canary jmgr2996/next.js feat/remove-some-react-unnecesary-imports Change
_error.js 844 kB 844 kB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.81 kB 3.81 kB ✓
index.js 844 kB 844 kB ✓
link.js 882 kB 882 kB ✓
routerDirect.js 874 kB 874 kB ✓
withRouter.js 874 kB 874 kB ✓
Overall change 4.33 MB 4.33 MB ✓

@kodiakhq kodiakhq bot merged commit 993b78d into vercel:canary May 20, 2020
chibicode pushed a commit to chibicode/next.js that referenced this pull request May 21, 2020
@teo-garcia @chibicode
chore: Remove some redundant imports (vercel#13066)
3056ab7 
This issue is related to [12694](vercel#12964). I covered the following examples


- with-zeit-fetch
- with-yarn-workspaces
- with-why-did-your-render
- with-video-js
- with-universal-configuration-runtime
- with-typestyle
- with-three-js

If you have a suggestion or change I'd appreciate it
chibicode added a commit to chibicode/next.js that referenced this pull request May 21, 2020
@chibicode
Merge remote-tracking branch 'upstream/canary' into strapi-blog-starter
f4729bd 
* upstream/canary: (143 commits)
  Remove old ErrorComponent global
  Remove unnecessary loadGetInitialProps (vercel#13159)
  Remove dead events (vercel#13156)
  v9.4.2
  v9.4.2-canary.5
  Record presence of `reportWebVitals` (vercel#13155)
  Feat/remove redundant imports from examples (vercel#13062)
  Fix Windows LogBox Test (vercel#13147)
  Eliminate array destructuring assignment (vercel#13151)
  Update Create Next App to handle rename of org (vercel#13138)
  v9.4.2-canary.4
  Correctly eliminate destructuring assignment (vercel#13144)
  Fix the link for Custom Server documentation (vercel#13137)
  Upgrade Next Redux Wrapper to version 6 in examples (vercel#11802)
  Enable jest/no-try-expect (vercel#13124)
  GranularChunks conformance check (vercel#11710)
  With stitches (vercel#12677)
  chore: Remove some redundant imports (vercel#13066)
  Use `eval-source-map` for Server Side Errors (vercel#13123)
  [Examples] Fix with-yarn-workspaces Vercel deploy button (vercel#12867)
  ...
rokinsky pushed a commit to rokinsky/next.js that referenced this pull request Jul 11, 2020
@teo-garcia @rokinsky
chore: Remove some redundant imports (vercel#13066)
b53ee3d 
This issue is related to [12694](vercel#12964). I covered the following examples


- with-zeit-fetch
- with-yarn-workspaces
- with-why-did-your-render
- with-video-js
- with-universal-configuration-runtime
- with-typestyle
- with-three-js

If you have a suggestion or change I'd appreciate it
@vercel vercel locked as resolved and limited conversation to collaborators Jan 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Timer Timer Timer approved these changes

@lfades lfades Awaiting requested review from lfades

Assignees
No one assigned
Labels
examples Issue was opened via the examples template.
Projects
None yet
Milestone
9.4.2
Development

Successfully merging this pull request may close these issues.
3 participants
@teo-garcia @ijjk @Timer