Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove redundant imports in several examples #13030

Merged
merged 1 commit into from
May 18, 2020
Merged

chore: Remove redundant imports in several examples #13030

merged 1 commit into from
May 18, 2020

Conversation

teo-garcia
Copy link
Contributor

This issue is related to 12694. I covered the following examples

  • auth0
  • with-apollo
  • with-apollo-and-redux
  • with-context-api
  • with-docker
  • with-emotion
  • with-redux-observable
  • with-redux-persist
  • with-redux-saga
  • with-redux-thunk
  • with-redux-toolkit
  • with-styled-components

If you have a suggestion or change I'd appreciate it

@teo-garcia teo-garcia requested review from lfades and Timer as code owners May 18, 2020 04:04
@ijjk
Copy link
Member

ijjk commented May 18, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
zeit/next.js canary jmgr2996/next.js feat/remove-severals-react-imports Change
buildDuration 12.9s 13.4s ⚠️ +523ms
nodeModulesSize 58.5 MB 58.5 MB
Page Load Tests Overall decrease ⚠️
zeit/next.js canary jmgr2996/next.js feat/remove-severals-react-imports Change
/ failed reqs 0 0
/ total time (seconds) 2.197 2.354 ⚠️ +0.16
/ avg req/sec 1137.81 1061.88 -75.93
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.459 1.47 ⚠️ +0.01
/error-in-render avg req/sec 1713.36 1700.79 -12.57
Client Bundles (main, webpack, commons)
zeit/next.js canary jmgr2996/next.js feat/remove-severals-react-imports Change
main-HASH.js gzip 6.67 kB 6.67 kB
webpack-HASH.js gzip 746 B 746 B
de003c3a9d30..e49d.js gzip 10.4 kB 10.4 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 57 kB 57 kB
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary jmgr2996/next.js feat/remove-severals-react-imports Change
main-HASH.module.js gzip 5.71 kB 5.71 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..dule.js gzip 6.85 kB 6.85 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 52.4 kB 52.4 kB
Legacy Client Bundles (polyfills)
zeit/next.js canary jmgr2996/next.js feat/remove-severals-react-imports Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB
Overall change 26.3 kB 26.3 kB
Client Pages
zeit/next.js canary jmgr2996/next.js feat/remove-severals-react-imports Change
_app.js gzip 1.26 kB 1.26 kB
_error.js gzip 3.28 kB 3.28 kB
hooks.js gzip 881 B 881 B
index.js gzip 222 B 222 B
link.js gzip 2.06 kB 2.06 kB
routerDirect.js gzip 279 B 279 B
withRouter.js gzip 278 B 278 B
Overall change 8.26 kB 8.26 kB
Client Pages Modern
zeit/next.js canary jmgr2996/next.js feat/remove-severals-react-imports Change
_app.module.js gzip 604 B 604 B
_error.module.js gzip 2.09 kB 2.09 kB
hooks.module.js gzip 383 B 383 B
index.module.js gzip 223 B 223 B
link.module.js gzip 1.52 kB 1.52 kB
routerDirect..dule.js gzip 281 B 281 B
withRouter.m..dule.js gzip 278 B 278 B
Overall change 5.38 kB 5.38 kB
Client Build Manifests
zeit/next.js canary jmgr2996/next.js feat/remove-severals-react-imports Change
_buildManifest.js gzip 61 B 61 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 122 B 122 B
Rendered Page Sizes
zeit/next.js canary jmgr2996/next.js feat/remove-severals-react-imports Change
index.html gzip 926 B 926 B
link.html gzip 936 B 936 B
withRouter.html gzip 923 B 923 B
Overall change 2.79 kB 2.79 kB

Serverless Mode
General
zeit/next.js canary jmgr2996/next.js feat/remove-severals-react-imports Change
buildDuration 13.6s 13.7s ⚠️ +82ms
nodeModulesSize 58.5 MB 58.5 MB
Client Bundles (main, webpack, commons)
zeit/next.js canary jmgr2996/next.js feat/remove-severals-react-imports Change
main-HASH.js gzip 6.67 kB 6.67 kB
webpack-HASH.js gzip 746 B 746 B
de003c3a9d30..e49d.js gzip 10.4 kB 10.4 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 57 kB 57 kB
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary jmgr2996/next.js feat/remove-severals-react-imports Change
main-HASH.module.js gzip 5.71 kB 5.71 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..dule.js gzip 6.85 kB 6.85 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 52.4 kB 52.4 kB
Legacy Client Bundles (polyfills)
zeit/next.js canary jmgr2996/next.js feat/remove-severals-react-imports Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB
Overall change 26.3 kB 26.3 kB
Client Pages
zeit/next.js canary jmgr2996/next.js feat/remove-severals-react-imports Change
_app.js gzip 1.26 kB 1.26 kB
_error.js gzip 3.28 kB 3.28 kB
hooks.js gzip 881 B 881 B
index.js gzip 222 B 222 B
link.js gzip 2.06 kB 2.06 kB
routerDirect.js gzip 279 B 279 B
withRouter.js gzip 278 B 278 B
Overall change 8.26 kB 8.26 kB
Client Pages Modern
zeit/next.js canary jmgr2996/next.js feat/remove-severals-react-imports Change
_app.module.js gzip 604 B 604 B
_error.module.js gzip 2.09 kB 2.09 kB
hooks.module.js gzip 383 B 383 B
index.module.js gzip 223 B 223 B
link.module.js gzip 1.52 kB 1.52 kB
routerDirect..dule.js gzip 281 B 281 B
withRouter.m..dule.js gzip 278 B 278 B
Overall change 5.38 kB 5.38 kB
Client Build Manifests
zeit/next.js canary jmgr2996/next.js feat/remove-severals-react-imports Change
_buildManifest.js gzip 61 B 61 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 122 B 122 B
Serverless bundles
zeit/next.js canary jmgr2996/next.js feat/remove-severals-react-imports Change
_error.js 850 kB 850 kB
404.html 4.18 kB 4.18 kB
hooks.html 3.81 kB 3.81 kB
index.js 851 kB 851 kB
link.js 888 kB 888 kB
routerDirect.js 880 kB 880 kB
withRouter.js 880 kB 880 kB
Overall change 4.36 MB 4.36 MB

@Timer Timer added the examples Issue was opened via the examples template. label May 18, 2020
@Timer Timer added this to the 9.4.2 milestone May 18, 2020
@Timer Timer changed the title feat: Remove redundant imports in several examples chore: Remove redundant imports in several examples May 18, 2020
@Timer Timer merged commit dd264f5 into vercel:canary May 18, 2020
chibicode pushed a commit to chibicode/next.js that referenced this pull request May 21, 2020
rokinsky pushed a commit to rokinsky/next.js that referenced this pull request Jul 11, 2020
@vercel vercel locked as resolved and limited conversation to collaborators Jan 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
examples Issue was opened via the examples template.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants