-
Notifications
You must be signed in to change notification settings - Fork 27.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
An example with react-helmet #1264
Merged
Merged
Changes from 8 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
94ad64b
upload example
34b418b
fix
fae8058
fix
4309a55
fix
b72e285
fix .babelrc
f345503
fix standard style
4f51755
fix indent
8a7b358
rename helmetHead to helmet
49376e8
added gitignore
d6c263c
package.json
75428ff
removed yarn.lock
a66dfd4
Added more examples of using react-helmet
82dd379
removed gitignore
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Binary file not shown.
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
|
||
# react-helmet example | ||
|
||
## How to use | ||
|
||
Download the example [or clone the repo](https://github.com/zeit/next.js): | ||
|
||
```bash | ||
curl https://codeload.github.com/zeit/next.js/tar.gz/master | tar -xz --strip=2 next.js-master/examples/with-react-helmet | ||
cd with-react-helmet | ||
``` | ||
|
||
Install it and run: | ||
|
||
```bash | ||
npm install | ||
npm run dev | ||
``` | ||
_Or alternatively:_ | ||
```bash | ||
yarn | ||
yarn run dev | ||
``` | ||
|
||
|
||
Deploy it to the cloud with [now](https://zeit.co/now) ([download](https://zeit.co/download)) | ||
|
||
```bash | ||
now | ||
``` | ||
## Notes | ||
This an minimalistic example of how to combine next.js and [react-helmet](https://github.com/nfl/react-helmet). | ||
The title of the page shall be changed to "Hello next.js!" | ||
The rest is all up to you. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
{ | ||
"name": "with-react-helmet", | ||
"scripts": { | ||
"dev": "next", | ||
"build": "next build", | ||
"start": "next start" | ||
}, | ||
"dependencies": { | ||
"next": "^2.0.0-beta", | ||
"react": "^15.4.2", | ||
"react-bootstrap": "^0.30.7", | ||
"react-dom": "^15.4.2", | ||
"react-helmet": "^4.0.0" | ||
} | ||
} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please add author license and version to be consistent with https://github.com/zeit/next.js/blob/master/examples/basic-css/package.json#L14-L15 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,43 @@ | ||
import Document, { Head, Main, NextScript } from 'next/document' | ||
import Helmet from 'react-helmet' | ||
|
||
export default class extends Document { | ||
static async getInitialProps ({ renderPage }) { | ||
const page = renderPage() | ||
|
||
// see https://github.com/nfl/react-helmet#server-usage for more information | ||
// 'head' was occupied by 'page.head', we cannot use it | ||
return { ...page, helmet: Helmet.rewind() } | ||
} | ||
|
||
// should render on <html> | ||
get helmetHtmlAttrComponents () { | ||
return this.props.helmet.htmlAttributes.toComponent() | ||
} | ||
|
||
// should render on <head> | ||
get helmetHeadComponents () { | ||
return Object.keys(this.props.helmet) | ||
.filter(el => el !== 'htmlAttributes') // remove htmlAttributes which is not for <head> but for <html> | ||
.map(el => this.props.helmet[el].toComponent()) | ||
} | ||
|
||
get helmetJsx () { | ||
return (<Helmet | ||
title='Hello next.js!' | ||
/>) | ||
} | ||
|
||
render () { | ||
return (<html {...this.helmetHtmlAttrComponents}> | ||
<Head> | ||
{ this.helmetJsx } | ||
{ this.helmetHeadComponents } | ||
</Head> | ||
<body> | ||
<Main /> | ||
<NextScript /> | ||
</body> | ||
</html>) | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
export default () => (<div> | ||
Hello World! | ||
</div>) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to be an unused dependency 🤔