Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update block-starter example w/ getServerSideProps #11034

Conversation

pavanetti
Copy link
Contributor

Related to #11014

@pavanetti pavanetti requested review from lfades and Timer as code owners March 13, 2020 03:10
@ijjk
Copy link
Member

ijjk commented Mar 13, 2020

Stats from current PR

Default Server Mode
General
zeit/next.js canary carlospavanetti/next.js update-blog-starter-example-with-getServerProps Change
buildDuration 10.4s 10.4s ⚠️ +51ms
nodeModulesSize 56.6 MB 56.6 MB
Client Bundles (main, webpack, commons)
zeit/next.js canary carlospavanetti/next.js update-blog-starter-example-with-getServerProps Change
main-HASH.js gzip 5.77 kB 5.77 kB
webpack-HASH.js gzip 746 B 746 B
de003c3a9d30..8eb0.js gzip 9.78 kB 9.78 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 55.4 kB 55.4 kB
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary carlospavanetti/next.js update-blog-starter-example-with-getServerProps Change
main-HASH.module.js gzip 4.78 kB 4.78 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..dule.js gzip 6.71 kB 6.71 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 51.4 kB 51.4 kB
Legacy Client Bundles (polyfills)
zeit/next.js canary carlospavanetti/next.js update-blog-starter-example-with-getServerProps Change
polyfills-HASH.js gzip 26.2 kB 26.2 kB
Overall change 26.2 kB 26.2 kB
Client Pages
zeit/next.js canary carlospavanetti/next.js update-blog-starter-example-with-getServerProps Change
_app.js gzip 1.09 kB 1.09 kB
_error.js gzip 2.96 kB 2.96 kB
hooks.js gzip 664 B 664 B
index.js gzip 222 B 222 B
link.js gzip 1.89 kB 1.89 kB
routerDirect.js gzip 279 B 279 B
withRouter.js gzip 278 B 278 B
Overall change 7.38 kB 7.38 kB
Client Pages Modern
zeit/next.js canary carlospavanetti/next.js update-blog-starter-example-with-getServerProps Change
_app.module.js gzip 594 B 594 B
_error.module.js gzip 2.06 kB 2.06 kB
hooks.module.js gzip 370 B 370 B
index.module.js gzip 212 B 212 B
link.module.js gzip 1.48 kB 1.48 kB
routerDirect..dule.js gzip 271 B 271 B
withRouter.m..dule.js gzip 270 B 270 B
Overall change 5.26 kB 5.26 kB
Client Build Manifests
zeit/next.js canary carlospavanetti/next.js update-blog-starter-example-with-getServerProps Change
_buildManifest.js gzip 61 B 61 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 122 B 122 B
Rendered Page Sizes
zeit/next.js canary carlospavanetti/next.js update-blog-starter-example-with-getServerProps Change
index.html gzip 914 B 914 B
link.html gzip 922 B 922 B
withRouter.html gzip 910 B 910 B
Overall change 2.75 kB 2.75 kB

Serverless Mode (Increase detected ⚠️)
General
zeit/next.js canary carlospavanetti/next.js update-blog-starter-example-with-getServerProps Change
buildDuration 11.2s 11.2s -11ms
nodeModulesSize 56.6 MB 56.6 MB
Client Bundles (main, webpack, commons)
zeit/next.js canary carlospavanetti/next.js update-blog-starter-example-with-getServerProps Change
main-HASH.js gzip 5.77 kB 5.77 kB
webpack-HASH.js gzip 746 B 746 B
de003c3a9d30..8eb0.js gzip 9.78 kB 9.78 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 55.4 kB 55.4 kB
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary carlospavanetti/next.js update-blog-starter-example-with-getServerProps Change
main-HASH.module.js gzip 4.78 kB 4.78 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..dule.js gzip 6.71 kB 6.71 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 51.4 kB 51.4 kB
Legacy Client Bundles (polyfills)
zeit/next.js canary carlospavanetti/next.js update-blog-starter-example-with-getServerProps Change
polyfills-HASH.js gzip 26.2 kB 26.2 kB
Overall change 26.2 kB 26.2 kB
Client Pages
zeit/next.js canary carlospavanetti/next.js update-blog-starter-example-with-getServerProps Change
_app.js gzip 1.09 kB 1.09 kB
_error.js gzip 2.96 kB 2.96 kB
hooks.js gzip 664 B 664 B
index.js gzip 222 B 222 B
link.js gzip 1.89 kB 1.89 kB
routerDirect.js gzip 279 B 279 B
withRouter.js gzip 278 B 278 B
Overall change 7.38 kB 7.38 kB
Client Pages Modern
zeit/next.js canary carlospavanetti/next.js update-blog-starter-example-with-getServerProps Change
_app.module.js gzip 594 B 594 B
_error.module.js gzip 2.06 kB 2.06 kB
hooks.module.js gzip 370 B 370 B
index.module.js gzip 212 B 212 B
link.module.js gzip 1.48 kB 1.48 kB
routerDirect..dule.js gzip 271 B 271 B
withRouter.m..dule.js gzip 270 B 270 B
Overall change 5.26 kB 5.26 kB
Client Build Manifests
zeit/next.js canary carlospavanetti/next.js update-blog-starter-example-with-getServerProps Change
_buildManifest.js gzip 61 B 61 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 122 B 122 B
Serverless bundles Overall increase ⚠️
zeit/next.js canary carlospavanetti/next.js update-blog-starter-example-with-getServerProps Change
_error.js gzip 294 kB 293 kB -431 B
404.html gzip 1.32 kB 1.32 kB
hooks.html gzip 954 B 954 B
index.js gzip 293 kB 294 kB ⚠️ +735 B
link.js gzip 301 kB 301 kB ⚠️ +800 B
routerDirect.js gzip 300 kB 299 kB -379 B
withRouter.js gzip 300 kB 300 kB -4 B
Overall change 1.49 MB 1.49 MB ⚠️ +721 B

@@ -74,8 +74,8 @@ const Blog = ({ router, page = 1 }) => {
)
}

Blog.getInitialProps = async ({ query }) => {
return query ? { page: query.page } : {}
export async function getServerSideProps({ query }) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of all the examples this example should definitely use getStaticProps.

@pavanetti
Copy link
Contributor Author

Closing in favor of #11078

@pavanetti pavanetti closed this Mar 14, 2020
@vercel vercel locked as resolved and limited conversation to collaborators Jan 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants