Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update api-routes example to SSG #11019

Merged
merged 2 commits into from
Mar 12, 2020
Merged

Conversation

josiahwiebe
Copy link
Contributor

@josiahwiebe josiahwiebe commented Mar 12, 2020

Removes getInitialProps in favour of getStaticPaths and getStaticProps.

Changes the URL scheme for pages/person, was http://localhost:3000/person?id=1 now http://localhost:3000/person/1

Related to #11014

@ijjk
Copy link
Member

ijjk commented Mar 12, 2020

Stats from current PR

Default Server Mode
General
zeit/next.js canary josiahwiebe/next.js canary Change
buildDuration 9.8s 9.7s -125ms
nodeModulesSize 56.6 MB 56.6 MB
Client Bundles (main, webpack, commons)
zeit/next.js canary josiahwiebe/next.js canary Change
main-HASH.js gzip 5.77 kB 5.77 kB
webpack-HASH.js gzip 746 B 746 B
de003c3a9d30..cfaa.js gzip 9.77 kB 9.77 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 55.4 kB 55.4 kB
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary josiahwiebe/next.js canary Change
main-HASH.module.js gzip 4.78 kB 4.78 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..dule.js gzip 6.71 kB 6.71 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 51.4 kB 51.4 kB
Legacy Client Bundles (polyfills)
zeit/next.js canary josiahwiebe/next.js canary Change
polyfills-HASH.js gzip 26.2 kB 26.2 kB
Overall change 26.2 kB 26.2 kB
Client Pages
zeit/next.js canary josiahwiebe/next.js canary Change
_app.js gzip 1.09 kB 1.09 kB
_error.js gzip 2.96 kB 2.96 kB
hooks.js gzip 664 B 664 B
index.js gzip 222 B 222 B
link.js gzip 1.89 kB 1.89 kB
routerDirect.js gzip 279 B 279 B
withRouter.js gzip 278 B 278 B
Overall change 7.38 kB 7.38 kB
Client Pages Modern
zeit/next.js canary josiahwiebe/next.js canary Change
_app.module.js gzip 594 B 594 B
_error.module.js gzip 2.06 kB 2.06 kB
hooks.module.js gzip 370 B 370 B
index.module.js gzip 212 B 212 B
link.module.js gzip 1.48 kB 1.48 kB
routerDirect..dule.js gzip 271 B 271 B
withRouter.m..dule.js gzip 270 B 270 B
Overall change 5.26 kB 5.26 kB
Client Build Manifests
zeit/next.js canary josiahwiebe/next.js canary Change
_buildManifest.js gzip 61 B 61 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 122 B 122 B
Rendered Page Sizes
zeit/next.js canary josiahwiebe/next.js canary Change
index.html gzip 914 B 914 B
link.html gzip 922 B 922 B
withRouter.html gzip 910 B 910 B
Overall change 2.75 kB 2.75 kB

Serverless Mode (Increase detected ⚠️)
General
zeit/next.js canary josiahwiebe/next.js canary Change
buildDuration 9.9s 10.6s ⚠️ +699ms
nodeModulesSize 56.6 MB 56.6 MB
Client Bundles (main, webpack, commons)
zeit/next.js canary josiahwiebe/next.js canary Change
main-HASH.js gzip 5.77 kB 5.77 kB
webpack-HASH.js gzip 746 B 746 B
de003c3a9d30..cfaa.js gzip 9.77 kB 9.77 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 55.4 kB 55.4 kB
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary josiahwiebe/next.js canary Change
main-HASH.module.js gzip 4.78 kB 4.78 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..dule.js gzip 6.71 kB 6.71 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 51.4 kB 51.4 kB
Legacy Client Bundles (polyfills)
zeit/next.js canary josiahwiebe/next.js canary Change
polyfills-HASH.js gzip 26.2 kB 26.2 kB
Overall change 26.2 kB 26.2 kB
Client Pages
zeit/next.js canary josiahwiebe/next.js canary Change
_app.js gzip 1.09 kB 1.09 kB
_error.js gzip 2.96 kB 2.96 kB
hooks.js gzip 664 B 664 B
index.js gzip 222 B 222 B
link.js gzip 1.89 kB 1.89 kB
routerDirect.js gzip 279 B 279 B
withRouter.js gzip 278 B 278 B
Overall change 7.38 kB 7.38 kB
Client Pages Modern
zeit/next.js canary josiahwiebe/next.js canary Change
_app.module.js gzip 594 B 594 B
_error.module.js gzip 2.06 kB 2.06 kB
hooks.module.js gzip 370 B 370 B
index.module.js gzip 212 B 212 B
link.module.js gzip 1.48 kB 1.48 kB
routerDirect..dule.js gzip 271 B 271 B
withRouter.m..dule.js gzip 270 B 270 B
Overall change 5.26 kB 5.26 kB
Client Build Manifests
zeit/next.js canary josiahwiebe/next.js canary Change
_buildManifest.js gzip 61 B 61 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 122 B 122 B
Serverless bundles Overall increase ⚠️
zeit/next.js canary josiahwiebe/next.js canary Change
_error.js gzip 293 kB 293 kB ⚠️ +109 B
404.html gzip 1.32 kB 1.32 kB
hooks.html gzip 954 B 954 B
index.js gzip 293 kB 293 kB -97 B
link.js gzip 301 kB 301 kB ⚠️ +265 B
routerDirect.js gzip 300 kB 299 kB -623 B
withRouter.js gzip 299 kB 300 kB ⚠️ +653 B
Overall change 1.49 MB 1.49 MB ⚠️ +307 B

Copy link
Member

@lfades lfades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@josiahwiebe Thank you 💯

@lfades lfades merged commit fe4da73 into vercel:canary Mar 12, 2020
@Timer Timer added the examples Issue was opened via the examples template. label Mar 13, 2020
@Timer Timer added this to the 9.3.1 milestone Mar 13, 2020
chibicode added a commit to chibicode/next.js that referenced this pull request Mar 16, 2020
* canary: (47 commits)
  v9.3.1-canary.5
  Update @next/bundle-analyzer dependencies (vercel#11068)
  Update preset.ts: Remove any and use updated Node.js types (vercel#11075)
  Upgrade styled-jsx (vercel#11070)
  Update ssr-caching example with getServerSideProps (vercel#11032)
  Add support for static 404 when _error does not have custom GIP (vercel#11062)
  update form handler example (vercel#11059)
  Update with-loading example to SSG (vercel#11050)
  Upgrade next.js version on datocms example (vercel#11039)
  Update custom-server-express example with getServerSideProps  (vercel#11035)
  Use getServerSideProps (vercel#11057)
  v9.3.1-canary.4
  Updated analyze-bundles example (vercel#11031)
  Update custom-server-fastify example to not use internal fn (vercel#11040)
  Correct Cache-Control Behavior for GS(S)P (vercel#11022)
  Update next-sass example to use built-in sass support (vercel#11015)
  Update with-zeit-fetch example to use SSG (vercel#11026)
  Update amp-first example to use GSSP (vercel#11028)
  Fix Test for Windows
  feat: update api-routes example to SSG (vercel#11019)
  ...
ScriptedAlchemy pushed a commit to module-federation/next.js that referenced this pull request Mar 17, 2020
* feat: update api-routes example to SSG

* Update examples/api-routes/components/Person.js

Co-authored-by: Luis Alvarez D <[email protected]>
@vercel vercel locked as resolved and limited conversation to collaborators Jan 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
examples Issue was opened via the examples template.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants