Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add params to getStaticProps on err.sh #10751

Merged
merged 2 commits into from
Mar 1, 2020
Merged

Add params to getStaticProps on err.sh #10751

merged 2 commits into from
Mar 1, 2020

Conversation

chibicode
Copy link
Member

@chibicode chibicode commented Feb 29, 2020 •
edited
Loading

getStaticProps takes { params } and I think it'd be helpful to mention that on this err.sh doc. #9524

@chibicode chibicode requested a review from Timer as a code owner February 29, 2020 16:51
@chibicode chibicode changed the title Add params to getStaticProps Add params to getStaticProps on err.sh Feb 29, 2020
@ijjk
Copy link
Member

ijjk commented Feb 29, 2020

Stats from current PR

Default Server Mode
General
zeit/next.js canary zeit/next.js add-params-to-getstaticprops Change
buildDuration 9.8s 9.7s -30ms
nodeModulesSize 56.3 MB 56.3 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary zeit/next.js add-params-to-getstaticprops Change
main-HASH.js gzip 5.41 kB 5.41 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..7030.js gzip 9.68 kB 9.68 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 55 kB 55 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary zeit/next.js add-params-to-getstaticprops Change
main-HASH.module.js gzip 4.44 kB 4.44 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.63 kB 6.63 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 51 kB 51 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary zeit/next.js add-params-to-getstaticprops Change
polyfills-HASH.js gzip 18.9 kB 18.9 kB ✓
Overall change 18.9 kB 18.9 kB ✓
Client Pages
zeit/next.js canary zeit/next.js add-params-to-getstaticprops Change
_app.js gzip 1.07 kB 1.07 kB ✓
_error.js gzip 2.98 kB 2.98 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 1.9 kB 1.9 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.39 kB 7.39 kB ✓
Client Pages Modern
zeit/next.js canary zeit/next.js add-params-to-getstaticprops Change
_app.module.js gzip 589 B 589 B ✓
_error.module.js gzip 2.08 kB 2.08 kB ✓
hooks.module.js gzip 370 B 370 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 1.48 kB 1.48 kB ✓
routerDirect..dule.js gzip 271 B 271 B ✓
withRouter.m..dule.js gzip 270 B 270 B ✓
Overall change 5.27 kB 5.27 kB ✓
Client Build Manifests
zeit/next.js canary zeit/next.js add-params-to-getstaticprops Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
zeit/next.js canary zeit/next.js add-params-to-getstaticprops Change
index.html gzip 924 B 924 B ✓
link.html gzip 932 B 932 B ✓
withRouter.html gzip 922 B 922 B ✓
Overall change 2.78 kB 2.78 kB ✓
Serverless Mode (Increase detected ⚠️)
General
zeit/next.js canary zeit/next.js add-params-to-getstaticprops Change
buildDuration 10.6s 10.4s -239ms
nodeModulesSize 56.3 MB 56.3 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary zeit/next.js add-params-to-getstaticprops Change
main-HASH.js gzip 5.41 kB 5.41 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..7030.js gzip 9.68 kB 9.68 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 55 kB 55 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary zeit/next.js add-params-to-getstaticprops Change
main-HASH.module.js gzip 4.44 kB 4.44 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.63 kB 6.63 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 51 kB 51 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary zeit/next.js add-params-to-getstaticprops Change
polyfills-HASH.js gzip 18.9 kB 18.9 kB ✓
Overall change 18.9 kB 18.9 kB ✓
Client Pages
zeit/next.js canary zeit/next.js add-params-to-getstaticprops Change
_app.js gzip 1.07 kB 1.07 kB ✓
_error.js gzip 2.98 kB 2.98 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 1.9 kB 1.9 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.39 kB 7.39 kB ✓
Client Pages Modern
zeit/next.js canary zeit/next.js add-params-to-getstaticprops Change
_app.module.js gzip 589 B 589 B ✓
_error.module.js gzip 2.08 kB 2.08 kB ✓
hooks.module.js gzip 370 B 370 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 1.48 kB 1.48 kB ✓
routerDirect..dule.js gzip 271 B 271 B ✓
withRouter.m..dule.js gzip 270 B 270 B ✓
Overall change 5.27 kB 5.27 kB ✓
Client Build Manifests
zeit/next.js canary zeit/next.js add-params-to-getstaticprops Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles Overall increase ⚠️
zeit/next.js canary zeit/next.js add-params-to-getstaticprops Change
_error.js gzip 292 kB 292 kB ⚠️ +876 B
404.html gzip 1.33 kB 1.33 kB ✓
hooks.html gzip 963 B 963 B ✓
index.js gzip 292 kB 292 kB -560 B
link.js gzip 299 kB 299 kB -129 B
routerDirect.js gzip 298 kB 298 kB -167 B
withRouter.js gzip 298 kB 298 kB ⚠️ +424 B
Overall change 1.48 MB 1.48 MB ⚠️ +444 B

Commit: 750ce92

@ijjk
Copy link
Member

ijjk commented Mar 1, 2020

Stats from current PR

Default Server Mode
General
zeit/next.js canary zeit/next.js add-params-to-getstaticprops Change
buildDuration 9.3s 9.5s ⚠️ +242ms
nodeModulesSize 56.3 MB 56.3 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary zeit/next.js add-params-to-getstaticprops Change
main-HASH.js gzip 5.41 kB 5.41 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..7030.js gzip 9.68 kB 9.68 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 55 kB 55 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary zeit/next.js add-params-to-getstaticprops Change
main-HASH.module.js gzip 4.44 kB 4.44 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.63 kB 6.63 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 51 kB 51 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary zeit/next.js add-params-to-getstaticprops Change
polyfills-HASH.js gzip 18.9 kB 18.9 kB ✓
Overall change 18.9 kB 18.9 kB ✓
Client Pages
zeit/next.js canary zeit/next.js add-params-to-getstaticprops Change
_app.js gzip 1.07 kB 1.07 kB ✓
_error.js gzip 2.98 kB 2.98 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 1.89 kB 1.89 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.38 kB 7.38 kB ✓
Client Pages Modern
zeit/next.js canary zeit/next.js add-params-to-getstaticprops Change
_app.module.js gzip 589 B 589 B ✓
_error.module.js gzip 2.08 kB 2.08 kB ✓
hooks.module.js gzip 370 B 370 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 1.48 kB 1.48 kB ✓
routerDirect..dule.js gzip 271 B 271 B ✓
withRouter.m..dule.js gzip 270 B 270 B ✓
Overall change 5.27 kB 5.27 kB ✓
Client Build Manifests
zeit/next.js canary zeit/next.js add-params-to-getstaticprops Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
zeit/next.js canary zeit/next.js add-params-to-getstaticprops Change
index.html gzip 924 B 924 B ✓
link.html gzip 932 B 932 B ✓
withRouter.html gzip 922 B 922 B ✓
Overall change 2.78 kB 2.78 kB ✓
Serverless Mode (Decrease detected ✓)
General
zeit/next.js canary zeit/next.js add-params-to-getstaticprops Change
buildDuration 11s 10.9s -105ms
nodeModulesSize 56.3 MB 56.3 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary zeit/next.js add-params-to-getstaticprops Change
main-HASH.js gzip 5.41 kB 5.41 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..7030.js gzip 9.68 kB 9.68 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 55 kB 55 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary zeit/next.js add-params-to-getstaticprops Change
main-HASH.module.js gzip 4.44 kB 4.44 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.63 kB 6.63 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 51 kB 51 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary zeit/next.js add-params-to-getstaticprops Change
polyfills-HASH.js gzip 18.9 kB 18.9 kB ✓
Overall change 18.9 kB 18.9 kB ✓
Client Pages
zeit/next.js canary zeit/next.js add-params-to-getstaticprops Change
_app.js gzip 1.07 kB 1.07 kB ✓
_error.js gzip 2.98 kB 2.98 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 1.89 kB 1.89 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.38 kB 7.38 kB ✓
Client Pages Modern
zeit/next.js canary zeit/next.js add-params-to-getstaticprops Change
_app.module.js gzip 589 B 589 B ✓
_error.module.js gzip 2.08 kB 2.08 kB ✓
hooks.module.js gzip 370 B 370 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 1.48 kB 1.48 kB ✓
routerDirect..dule.js gzip 271 B 271 B ✓
withRouter.m..dule.js gzip 270 B 270 B ✓
Overall change 5.27 kB 5.27 kB ✓
Client Build Manifests
zeit/next.js canary zeit/next.js add-params-to-getstaticprops Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles Overall decrease ✓
zeit/next.js canary zeit/next.js add-params-to-getstaticprops Change
_error.js gzip 292 kB 292 kB -424 B
404.html gzip 1.33 kB 1.33 kB ✓
hooks.html gzip 963 B 963 B ✓
index.js gzip 292 kB 292 kB ⚠️ +336 B
link.js gzip 300 kB 299 kB -385 B
routerDirect.js gzip 299 kB 298 kB -1 kB
withRouter.js gzip 298 kB 298 kB -130 B
Overall change 1.48 MB 1.48 MB -1.6 kB

Commit: e5d7502

@timneutkens timneutkens merged commit c52c038 into canary Mar 1, 2020
@timneutkens timneutkens deleted the add-params-to-getstaticprops branch March 1, 2020 14:20
@Timer Timer added this to the 9.3.0 milestone Mar 1, 2020
@chibicode
Copy link
Member Author

chibicode commented Mar 3, 2020 •
edited
Loading

@ijjk @timneutkens Actually, since ctx is optional, should we put ? after ctx?

-export async function getStaticProps(ctx: {
+export async function getStaticProps(ctx?: {

Never mind because it's unconditionally passed to the function.

@snyk-bot snyk-bot mentioned this pull request Apr 9, 2020
Open
@vercel vercel locked as resolved and limited conversation to collaborators Jan 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk ijjk approved these changes

@timneutkens timneutkens timneutkens approved these changes

@Timer Timer Awaiting requested review from Timer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
9.3.0
Development

Successfully merging this pull request may close these issues.
4 participants
@chibicode @ijjk @timneutkens @Timer