-
Notifications
You must be signed in to change notification settings - Fork 27.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests fails when lucide-react is used with Next 13.4.13 #53668
Comments
Looks like #53051 has not addressed some imports correctly, we will look into this! |
Any workaround in the meantime? |
@syntaxlexx try "lucide-react": "0.263.1", |
Same problem here, rolled back to 13.4.12 |
This was fixed in #53697, so closing. You can upgrade to |
this is not solved for me when using Next.js v13.4.16 and lucide-react v0.268.0. While solved during build runs, I am still getting this when doing any test run with Jest:
Reproducible with originally mentioned test case, but with upgraded Next.js: https://github.com/edenstrom/nextjs-bug-reproduction |
The latest versions of next and lucide-react do not play nicely with our jest configuration. So for the time being, we remove the tests that involved importing an icon, specifically the page.test.tsx file, which largely existed as an example test file. This issue was closed, but is still an issue: vercel/next.js#53668
|
Still running into this issue with |
Same here @msquinn |
Me as well |
This combination works to run jest tests:
It seems the problem stopped appearing from this version onwards: 13.4.20-canary.9 |
Works with
|
This closed issue has been automatically locked because it had no new activity for 2 weeks. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you. |
Verify canary release
Provide environment information
Operating System: Platform: darwin Arch: arm64 Version: Darwin Kernel Version 22.6.0: Wed Jul 5 22:22:05 PDT 2023; root:xnu-8796.141.3~6/RELEASE_ARM64_T6000 Binaries: Node: 18.16.0 npm: 9.5.1 Yarn: 1.22.19 pnpm: 8.3.1 Relevant Packages: next: 13.4.13 eslint-config-next: 13.4.12 react: 18.2.0 react-dom: 18.2.0 typescript: 5.1.6 Next.js Config: output: N/A
Which area(s) of Next.js are affected? (leave empty if unsure)
Jest (next/jest)
Link to the code that reproduces this issue or a replay of the bug
https://github.com/edenstrom/nextjs-bug-reproduction
To Reproduce
Relevant code in example above:
pnpm test
orjest
to run tests.next dev
and shows icon correctlyDescribe the Bug
Usage of
lucide-react
with Next.js13.4.13
crashes the tests.Expected Behavior
Module should correctly resolve and the tests should succeed.
Which browser are you using? (if relevant)
No response
How are you deploying your application? (if relevant)
No response
NEXT-1494
The text was updated successfully, but these errors were encountered: