-
Notifications
You must be signed in to change notification settings - Fork 27.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
next/image preload not working as expected in AppDir. Affecting LCP and FP. Order of preload is different than page-dir. #52995
Comments
Any update or ETA on this? Thanks for your efforts. |
This is an issue in React. I notified @gnoff who is going to fix it upstream. |
Hey @gnoff. Any issue, PR or ETA to track? Thank you for your contributions. |
This comment was marked as spam.
This comment was marked as spam.
No issue just yet but I think a general timeline of 2 weeks is reasonable. I'll try to update this issue with a link tracking the work once I get it started |
Please check #53574. If it is related or not. |
Hey @gnoff |
I believe this is the upstream React PR: |
…#53700) The root cause is `ReactDOM.preload()` inserts `<link rel="preload">` above the `<meta name="viewport">`. This PR adds a test to prove that upgrading React fixes the issue (see commits). - Depends on facebook/react#27201 - Depends on #53742 - Fixes #53574 - Related #52995
Do we expect that this issue has been fixed since the upstream react fixes were included in |
Confirmed this is fixed 👍 |
This closed issue has been automatically locked because it had no new activity for 2 weeks. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you. |
Verify canary release
Provide environment information
Operating System: Platform: darwin Arch: arm64 Version: Darwin Kernel Version 22.5.0: Thu Jun 8 22:22:19 PDT 2023; root:xnu-8796.121.3~7/RELEASE_ARM64_T8103 Binaries: Node: 16.20.0 npm: 8.19.4 Yarn: 1.22.19 pnpm: 8.6.0 Relevant Packages: next: 13.4.11 eslint-config-next: 13.4.11 react: 18.2.0 react-dom: 18.2.0 typescript: 5.1.6 Next.js Config: output: N/A
Which area(s) of Next.js are affected? (leave empty if unsure)
Image optimization (next/image, next/legacy/image)
Link to the code that reproduces this issue or a replay of the bug
https://github.com/gauravsaini964/image-preload-next13
To Reproduce
Describe the Bug
Order of image preload tag in app-dir is different from what it used to be in pages-dir and hence FP and LCP metric is getting affected. Same is replicated in lighthouse scores.
Compare following screenshots:
Expected Behavior
Image preload tag should come above every other preload tag imo as it is giving me best performance.
I have a ecommerce app which has 1800+ pages built with both app-router and page-router. App router app is faster in every aspect apart from FP and LCP metric consistently by ~1seconds because that website has lot more scripts to preload.
Which browser are you using? (if relevant)
Chrome
How are you deploying your application? (if relevant)
Vercel
NEXT-1463
The text was updated successfully, but these errors were encountered: