Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples require root Next.js project installation #4751

Closed
michaeljonathanblack opened this issue Jul 9, 2018 · 4 comments
Closed

examples require root Next.js project installation #4751

michaeljonathanblack opened this issue Jul 9, 2018 · 4 comments
Labels
good first issue Easy to fix issues, good for newcomers

Comments

@michaeljonathanblack
Copy link

Examples bug report

Example name

All examples

Describe the bug

Tim's description, via Slack:

Basically the problem is that next Will look for a babelrc
Which it finds in examples
But that has to reference the built file
As it can’t Find the next/babel of the dir it’s running from
Previously we had a custom property in .babelrc to disable the tree lookup, but babel 7 is strict
It validates the file
It’ll also be fixed once we move to a different directory structure

To Reproduce

Steps to reproduce the behavior, please provide code snippets or a repository:

  1. Go to https://github.com/zeit/next.js/tree/canary/examples/with-next-routes
  2. Follow installation instructions by cloning Next.js, cd with-next-routes, etc.
  3. Encounter error:
Module build failed: Error: Cannot find module './dist/build/babel/preset'

Expected behavior

It should run successfully without installing the root project.

@timneutkens timneutkens added help wanted good first issue Easy to fix issues, good for newcomers labels Jul 10, 2018
@timneutkens
Copy link
Member

Lets start with documenting this step in contributing.md.

@michaeljonathanblack
Copy link
Author

Is it related to contributing? I feel like this would be documented in each example, or maybe at the root readme (although there it would be overlooked)

@timneutkens
Copy link
Member

Posted a comment here #4758

timneutkens pushed a commit that referenced this issue Jul 11, 2018
Preferably this installation wouldn't be necessary, but in lieu of a fix...

#4751
@timneutkens
Copy link
Member

This has been solved.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Easy to fix issues, good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants