Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NEXT-732] The "error.tsx" code that I copy/pasted from the docs causes a linting error. #46573

Closed
1 task done
jazzypants1989 opened this issue Feb 28, 2023 · 2 comments · Fixed by #46898
Closed
1 task done

[NEXT-732] The "error.tsx" code that I copy/pasted from the docs causes a linting error. #46573

jazzypants1989 opened this issue Feb 28, 2023 · 2 comments · Fixed by #46898
Labels
linear: next Confirmed issue that is tracked by the Next.js team.

Comments

@jazzypants1989
Copy link

jazzypants1989 commented Feb 28, 2023 •
edited by timneutkens
Loading

Verify canary release

  • I verified that the issue exists in the latest Next.js canary release

Provide environment information

npx next info

Operating System:
  Platform: win32
  Arch: x64
  Version: Windows 10 Pro
Binaries:
  Node: 16.17.1
  npm: N/A
  Yarn: N/A
  pnpm: N/A
Relevant packages:
  next: 13.2.2-canary.3
  eslint-config-next: 13.2.1
  react: 18.2.0
  react-dom: 18.2.0

Which area(s) of Next.js are affected? (leave empty if unsure)

App directory (appDir: true)

Link to the code that reproduces this issue

https://github.com/jazzypants1989/nextjs-test

To Reproduce

Copy and paste the error.tsx provided by the docs into the app directory.

Describe the Bug

image

Why?

Expected Behavior

I expect to be able to copy and paste examples from the docs without causing a linting error.

Which browser are you using? (if relevant)

Doesn't matter

How are you deploying your application? (if relevant)

Doesn't matter.

NEXT-732
@jazzypants1989 jazzypants1989 added the bug Issue was opened via the bug report template. label Feb 28, 2023
@timneutkens timneutkens added linear: next Confirmed issue that is tracked by the Next.js team. kind: bug labels Mar 1, 2023
@timneutkens timneutkens changed the title The "error.tsx" code that I copy/pasted from the docs causes a linting error. [NEXT-732] The "error.tsx" code that I copy/pasted from the docs causes a linting error. Mar 1, 2023
@timneutkens timneutkens removed the bug Issue was opened via the bug report template. label Mar 1, 2023
@timneutkens
Copy link
Member

This is a bug, thanks for the report!

@shuding shuding mentioned this issue Mar 7, 2023
Merged
ijjk pushed a commit that referenced this issue Mar 7, 2023
@shuding
Fix TS plugin showing warning for error file's reset prop (#46898)
abf7da3 
This should be a special case of having a function as the client
boundary's prop. Fixes NEXT-732, fixes #46573.
@philwolstenholme philwolstenholme mentioned this issue Mar 7, 2023
Closed
@github-actions
Copy link
Contributor

github-actions bot commented Apr 7, 2023

This closed issue has been automatically locked because it had no new activity for a month. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
linear: next Confirmed issue that is tracked by the Next.js team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix TS plugin showing warning for error file's reset prop vercel/next.js
2 participants
@timneutkens @jazzypants1989