-
Notifications
You must be signed in to change notification settings - Fork 27.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NEXT-690] @next/font
does not respect https_proxy
environment variable
#45034
Labels
bug
Issue was opened via the bug report template.
linear: next
Confirmed issue that is tracked by the Next.js team.
Comments
github-actions
bot
added
the
linear: next
Confirmed issue that is tracked by the Next.js team.
label
Jan 19, 2023
This comment was marked as off-topic.
This comment was marked as off-topic.
timneutkens
added
linear: next
Confirmed issue that is tracked by the Next.js team.
and removed
linear: next
Confirmed issue that is tracked by the Next.js team.
labels
Feb 28, 2023
timneutkens
changed the title
[NEXT-690] Feb 28, 2023
@next/font
does not respect https_proxy
environment variable@next/font
does not respect https_proxy
environment variable
11 tasks
ijjk
pushed a commit
that referenced
this issue
Mar 8, 2023
When fetching CSS or font files from Google Fonts, it won't work if you're required to use a proxy. This change makes it look for the `http(s)_proxy` environment variable, and if it's defined it creates a fetch agent using [https-proxy-agent](https://github.com/TooTallNate/node-https-proxy-agent). Also fixes fetch errors not being properly logged. Fixes #45034 Closes NEXT-690 ## Bug - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Errors have a helpful link attached, see [`contributing.md`](https://github.com/vercel/next.js/blob/canary/contributing.md) ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] [e2e](https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. - [ ] Errors have a helpful link attached, see [`contributing.md`](https://github.com/vercel/next.js/blob/canary/contributing.md) ## Documentation / Examples - [ ] Make sure the linting passes by running `pnpm build && pnpm lint` - [ ] The "examples guidelines" are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md)
This closed issue has been automatically locked because it had no new activity for a month. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
bug
Issue was opened via the bug report template.
linear: next
Confirmed issue that is tracked by the Next.js team.
Verify canary release
Provide environment information
Which area(s) of Next.js are affected? (leave empty if unsure)
Font optimization (@next/font)
Link to the code that reproduces this issue
N/A
To Reproduce
npx create-next-app
@next/font
will be creatednpm run dev
behind a corporate proxy (withhttps_proxy
environment variable)Describe the Bug
Failed to fetch the font.
Dev server output:
Expected Behavior
Respect the
https_proxy
environment variable, and the font should be successfully retrieved.Which browser are you using? (if relevant)
No response
How are you deploying your application? (if relevant)
No response
NEXT-690
The text was updated successfully, but these errors were encountered: