bug(create-next-app): cli unpacks files it shouldn't from example path

[juliusmarminge]

Verify canary release

• I verified that the issue exists in the latest Next.js canary release

Provide environment information

next info not valid since it's not related to any specific repo

npx create-next-app --version
13.0.5-canary.2

What browser are you using? (if relevant)

No response

How are you deploying your application? (if relevant)

No response

Describe the Bug

When using the --example-path flag with the CLI, create-next-app ends up unpacking files it shouldn't.

For example, given a repo contains next-prisma-starter and next-prisma-starter-websockets, running npx create-next-app --example https://github.com/trpc/trpc --example-path examples/next-prisma-starter, create-next-app would combine the output with all the files matching both these directories, since it will unpack any file whose name starts with examples/next-prisma-starter.

This is the failing logic:

next.js/packages/create-next-app/helpers/examples.ts

Lines 103 to 106 in ecfd2f4

	filter: (p) =>
	p.startsWith(
	`${name}-${branch.replace(/\//g, '-')}${filePath ? `/${filePath}` : ''}`
	),

Expected Behavior

When running

npx create-next-app@canary --example https://github.com/trpc/trpc --example-path examples/next-prisma-starter

I expect the output repository to be the same as this: https://github.com/trpc/trpc/tree/next/examples/next-prisma-starter

Link to reproduction - Issues with a link to complete (but minimal) reproduction code will be addressed faster

https://github.com/juliusmarminge/create-next-app-bug-repro

To Reproduce

Run

npx create-next-app@canary --example https://github.com/trpc/trpc --example-path examples/next-prisma-starter

and browse to src/pages/api/auth. This file does not exist in the template repo, but is included in the outputted project created by the CLI

comparison:

expected: https://github.com/trpc/trpc/tree/next/examples/next-prisma-starter/src/pages/api
actual: https://github.com/juliusmarminge/create-next-app-bug-repro/tree/main/src/pages/api

[juliusmarminge]

Note: the repro no longer works (or fails if you look at it that way) since we renamed the example to not have this conflict, but it should be pretty easy to reproduce on any repo

trpc/trpc#3199

[github-actions]

This closed issue has been automatically locked because it had no new activity for a month. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.