Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

longitude and latitude are documented for NextRequest but not typed #31620

Closed
jokull opened this issue Nov 19, 2021 · 1 comment · Fixed by #31624
Closed

longitude and latitude are documented for NextRequest but not typed #31620

jokull opened this issue Nov 19, 2021 · 1 comment · Fixed by #31624
Labels
Middleware Related to Next.js Middleware. TypeScript Related to types with Next.js.

Comments

@jokull
Copy link

jokull commented Nov 19, 2021

What version of Next.js are you using?

12.0.4

What version of Node.js are you using?

16.13.0

What browser are you using?

Safari

What operating system are you using?

macOS

How are you deploying your application?

Vercel

Describe the Bug

According to the docs the geo object on NextRequest has longitude and latitude coordinates. However the types don't include them.

Expected Behavior

Would expect types to have those attributes.

To Reproduce

—
@jokull jokull added the bug Issue was opened via the bug report template. label Nov 19, 2021
@huozhi huozhi mentioned this issue Nov 19, 2021
Merged
3 tasks
@timneutkens timneutkens added Middleware Related to Next.js Middleware. TypeScript Related to types with Next.js. kind: bug and removed bug Issue was opened via the bug report template. labels Nov 19, 2021
@kodiakhq kodiakhq bot closed this as completed in #31624 Nov 19, 2021
kodiakhq bot pushed a commit that referenced this issue Nov 19, 2021
@huozhi
Add types for geo lat and long (#31624)
dab7b40 
Fixes #31620

## Bug

- [x] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Errors have helpful link attached, see `contributing.md`
@balazsorban44
Copy link
Member

This issue has been automatically locked due to no recent activity. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
natew pushed a commit to natew/next.js that referenced this issue Feb 16, 2022
@huozhi @natew
Add types for geo lat and long (vercel#31624)
6cb1d47 
Fixes vercel#31620

## Bug

- [x] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Errors have helpful link attached, see `contributing.md`
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Middleware Related to Next.js Middleware. TypeScript Related to types with Next.js.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add types for geo lat and long huozhi/next.js
3 participants
@jokull @timneutkens @balazsorban44