Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Manually adding meta charSet produces duplicate tag #27142

Closed
blainegarrett opened this issue Jul 13, 2021 · 4 comments
Closed

Manually adding meta charSet produces duplicate tag #27142

blainegarrett opened this issue Jul 13, 2021 · 4 comments
Labels
bug Issue was opened via the bug report template. please verify canary Please verify the issue with the latest canary branch.

Comments

@blainegarrett
Copy link

What version of Next.js are you using?

11.0.0

What version of Node.js are you using?

v12.16.1

What browser are you using?

Chrome

What operating system are you using?

macOS

How are you deploying your application?

n/a

Describe the Bug

Inside of a custom _document.tsx, adding <meta charSet="utf-8" /> produces a duplicate tag in the server rendered output. This appears counter to the description in: #270

The reason for manually adding the charset meta tag is to move the tag higher up in the to get around the schema validation error: "A charset attribute on a meta element found after the first 1024 bytes." It currently appears to be auto added at the end of the head contents from the _document.js and before other head tags (such as page level <title></title>).

Expected Behavior

If a manually added tag is used in a , that tag is utilized and there isn't a duplicate tag.

To Reproduce

Create a _document.tsx/.js with the following content and count the number of occurrences of the tag. It will be 2 - the one manually added and the one auto added.

import React from 'react';
import NextDocument, { Html, Head, Main, NextScript, DocumentContext } from 'next/document';
class Document extends NextDocument {
  render(): JSX.Element {
    return (
      <Html lang="en" dir="ltr" itemScope itemType="http://schema.org/WebPage">
        <Head>
          <meta charSet="utf-8" id="intendedCharset"/>
        </Head>
                <body>
          <Main />
          <NextScript />
        </body>
      </Html>
    );
  }
}
export default Document;

Render and inspect output. See duplicate tags.
@blainegarrett blainegarrett added the bug Issue was opened via the bug report template. label Jul 13, 2021
@blainegarrett blainegarrett changed the title Manually adding meta charSet produces duplicate ta Manually adding meta charSet produces duplicate tag Jul 13, 2021
@blainegarrett
Copy link
Author

blainegarrett commented Jul 13, 2021 •
edited
Loading

This may be due to a larger duplicate tag issue: #27142 and, in my case, would be moot with: #26534 as I'm merely trying to move the charset higher in the output tag. Feel free to close as duplicate if you see fit.

@valoricDe valoricDe mentioned this issue Oct 12, 2021
Merged
3 tasks
@TyMick TyMick mentioned this issue Nov 1, 2021
Closed
@jankaifer jankaifer added the please verify canary Please verify the issue with the latest canary branch. label Nov 29, 2022
@jankaifer
Copy link
Contributor

Please verify that your issue can be recreated with next@canary.

Why was this issue marked with the please verify canary label?

We noticed the provided reproduction was using an older version of Next.js, instead of canary.

The canary version of Next.js ships daily and includes all features and fixes that have not been released to the stable version yet. You can think of canary as a public beta. Some issues may already be fixed in the canary version, so please verify that your issue reproduces by running npm install next@canary and test it in your project, using your reproduction steps.

If the issue does not reproduce with the canary version, then it has already been fixed and this issue can be closed.

How can I quickly verify if my issue has been fixed in canary?

The safest way is to install next@canary in your project and test it, but you can also search through closed Next.js issues for duplicates or check the Next.js releases.

My issue has been open for a long time, why do I need to verify canary now?

Next.js does not backport bug fixes to older versions of Next.js. Instead, we are trying to introduce only a minimal amount of breaking changes between major releases.

What happens if I don't verify against the canary version of Next.js?

An issue with the please verify canary that receives no meaningful activity (e.g. new comments that acknowledge verification against canary) will be automatically closed and locked after 30 days.

If your issue has not been resolved in that time and it has been closed/locked, please open a new issue, with the required reproduction, using next@canary.

I did not open this issue, but it is relevant to me, what can I do to help?

Anyone experiencing the same issue is welcome to provide a minimal reproduction (following the above steps). Furthermore, you can upvote the issue (using the 👍 reaction on the topmost comment, instead of commenting "I have the same issue" etc.). Then, we can sort issues by engagement to prioritize.

I think my reproduction is good enough, why aren't you looking into it quicker?

We look into every Next.js issue and constantly monitor open issues for new comments.

However, sometimes we might miss one or two due to the popularity/high traffic of the repository. We apologize, and kindly ask you to refrain from tagging core maintainers, as that will usually not result in increased priority.

Upvoting issues to show your interest will help us prioritize and address them as quickly as possible. That said, every issue is important to us, and if an issue gets closed by accident, we encourage you to open a new one linking to the old issue and we will look into it.

Useful Resources

@balazsorban44
Copy link
Member

This issue has been automatically closed because it wasn't verified against next@canary. If you think it was closed by accident, please leave a comment. If you are running into a similar issue, please open a new issue with a reproduction. Thank you.

@github-actions
Copy link
Contributor

This closed issue has been automatically locked because it had no new activity for a month. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Issue was opened via the bug report template. please verify canary Please verify the issue with the latest canary branch.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@blainegarrett @jankaifer @balazsorban44