-
Notifications
You must be signed in to change notification settings - Fork 27.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom Cache-Control response header for /_next/image
#19914
Comments
/_next/image
/_next/image
/_next/image
/_next/image
Are there any update here? |
Any updates? Lighthouse is lowering my score because I must serve the images with a more efficient cache policy |
I had to rollback to next |
Hi, I think I just had the same problem... And I found a solution to it. TL;DR: just set the cache-control header from your provided images, pointed by the Context:
I tried:
=> But still have the issue. I cannot control the cache of After diving a bit more into that, I found somewhere in the Vercel documentation where they clearly explain why it behaves like this, and therefore I suppose it is not a bug. It says:
So I just gave it a try, by setting the cache-control header directly on my files hosted on my S3 bucket. I first seen no changes and I thought "oh well... It is definitively bugged..." but like 20min later, when I was into something else, I just found that it actually worked !!!! it just take time to get the CDN aware of your changes on the original resource. I don't understand why, because the default TTL must be 60sec, but anyway... It works. So I hope it helps, tell me if your issue wasn't exactly this, but I'm sure it will help someone one day so I posted this here. |
Hi @PaulSenon ! I'm gonna try your solution right now. I'm hosting my images in Wordpress so I've added this code into my .htaccess:
|
@PaulSenon It works! 🎉 |
@aresrioja10 Cool! Glad it helped! @jerrygreen as you opened this issue, please give a try to this solution and eventually close the issue if it solves your problem too :) |
I don't think this fixes the issue if you are hosting the images locally with next, e.g. the path is |
Not sure if it applies to your particular case, but here's what I could find out with my own tests. >>> I don't set any DEVThe Don't forget to disable the When cache is active, the image is cached correctly (response 304 Not Modified). When revalidating to know if the cache is ok, it checks the Given the cache mechanism used here, there will still be a network call to validate the image hasn't changed, but it's a few bytes instead of the normal KB. Verdict => It works as expected PRODThe Don't forget to disable the When cache is active, the image is cached correctly (response 304 Not Modified). When revalidating to know if the cache is ok, it checks the Given the cache mechanism used here, there will still be a network call to validate the image hasn't changed, but it's a few bytes instead of the normal KB. Verdict => It works as expected Branches deployed on commitsI would need to check, but I think the cache is always disabled in this case. Which is kind of expected I guess, you're not supposed to run much on these anyway. |
I'm getting forced loadings every page load on Safari, Brave, Chrome and FireFox, multiple people have reported similar to me also. Caching is not working. |
So I was able to figure out that my problem was that |
Not sure if this should be a separate issue but since I've seen it mentioned here I'll comment here. Basically I'm getting This is on a private hosted server (not vercel) in prod (not dev). All other routes / pages return the correct header. Only If On vercel (taken from this, I haven't tried hosting my site on vercel yet):
(Edit: After some new tests on Vercel, the source's max-age header is properly honored, still not the case on private server tho) On my server (next 10.0.4):
Not sure if I'm missing some config on my server that explains the missing headers but it's a pretty barebone default nginx proxy. This seems like a bug (for private server at least) and being able to specify the cache-control in the next js config would be great, otherwise it's still possible to fix with a custom rule in nginx but the default behavior seems like a poor experience. |
@starburst997 I think the cache isn't for the header and caching locally but for serving cached versions from |
I see! That would explains it then, still you would think that if they check the Here's an example of the "flashing" that occurs because the https://mot9t.sse.codesandbox.io/ The first image sends
The second is hosted on vercel and use the image optimizer
(Edit: After some new tests on Vercel, the source's max-age header is properly honored, still not the case on private server tho) Here's a gif RPReplay_Final1609621051.mp4Notice how the second image hosted on vercel with max-age=0 flickers. It is particularly annoying when going back / forward in the history or with an infinite scroller Being able to at least override this |
@starburst997 I agree, there's something wonky about |
@starburst997 Just to be sure, is your example has a normal I ask because If your page is static or server rendered, the first paint doesn't include the image because Have you tried the Have you tried the
|
@TheThirdRace I can confirm that neither |
@TheThirdRace I posted the code source of the example and I though it was clear but I will try to re-explain because I think this is an important issue that needs to fixed: Image 1 is loaded and has a response header with (Edit: After some new tests on Vercel, the source's max-age header is properly honored, still not the case on private server tho) On Safari iOS, you can see how Vercel's image flicker but not the first one. This has nothing to do with hydrating / lazy loading or the likes. Edit: Yes in the example I use |
@starburst997 Unfortunately, I never found the source code, all I saw was the link to the codesandbox running (https://mot9t.sse.codesandbox.io/), but no code was available... Given the "new" information from you and @danbeneventano, I can only stand with you guys. What happens if you configure the If you do, then Personally, I think NextJs went too far with their
They gave us a wonderful solution if used exactly the way they intended, but you're gonna be in trouble if you want to change anything in the tightly integrated process. Which is a big letdown in my opinion... Given there's some time before I release what I'm building with NextJs, I'll wait and see what happens, but I'm also thinking of simply switching back to a plain old |
@TheThirdRace I should've posted the link to the editor on the first post but you can get the editor link easily in any codesandbox ( " might not be the component you need", things is, it is exactly the component I was looking for, it works perfectly in my use-case, I just want a way to be able to set the I must admit I didn't look too far into it, but why would the image component absolutely need the |
You mean you put Because if I read the documentation, there's no mention of that prop except that it's supposedly not passed to the image... https://nextjs.org/docs/api-reference/next/image#other-props I must rectify my statement, it's only I've tested the default I'm also banging my head on the wall with the CSS part... Images don't have sizes when using layout='responsive', they're kinda floating (using I'm currently fighting a lot with the NextImage component, getting pretty tired of it actually. :( |
@stefanprobst At build time, you can check the static images produced in your The image optimization really happens at run time:
For truly static image optimization, NextJs would have to offer a configuration in There are downsides to truly static image optimization, such as:
The current So long story short, no there isn't any build time image optimization for markdown content. In fact there isn't any build time image optimization at all. |
@TheThirdRace Thank for reply and thank for precise detail about next.js image optimization system 🙏 |
@Amir-Mirkamali While really unintuitive, there is a way to set the All you need to do is to configure your hosting service to serve images with the For hosting services like AWS, I think you can set the |
Thanks for this explanation @TheThirdRace 👍
Wouldn't |
@MaximeBernard To be able to use an But because your image is cached up to a year, then you need to change the filename if you want the clients to update to the new image instantly otherwise the browser will simply serve the image in cache. |
Still, I think that etag and current cache-control system is useless for us. I want to serve my image with one week cache and I want to modify that cache in next.config.js file but it’s not possible now. |
Take a look at PR #26739 which will preserve the upstream This will support the first use case ( However, we won't be supporting the use case for Furthermore, we plan to build |
This solves the main use case from Issue #19914. Previously, we would set the `Cache-Control` header to a constant and rely on the server cache. This would mean the browser would always request the image and the server could response with 304 Not Modified to omit the response body. This PR changes the behavior such that the `max-age` will propagate from the upstream server to the Next.js Image Optimization Server and allow browser caching. ("upstream" meaning external server or just an internal route to an image) This PR does not change the `max-age` for static imports which will remain `public, max-age=315360000, immutable`. #### Pros: - Fewer HTTP requests after initial browser visit - User configurable `max-age` via the upstream image `Cache-Control` header #### Cons: - ~~Might be annoying for `next dev` when modifying a source image~~ (solved: use `max-age=0` for dev) - Might cause browser to cache longer than expected (up to 2x longer than the server cache if requested in the last second before expiration) ## Bug - [x] Related issues linked using `fixes #number`
@styfle So how can I prevent my application to always use the file on the server if all my images come from an headless system (directus9)? The headers sent by directus are ignored when I use the next/image component. Therefore when a user revisits my website the load time for images is always unacceptable due to that fact that the images are always reloaded from the server. Maybe I just missed something? |
About the PRJust to clarify, could you confirm the PR will have these effects:
EtagsBefore this PR, the
This behavior isn't ideal though as it prevents some fallback situations. Example
With an Even with static images, which use My point is, there's only benefits to include the Cloudinary behaviorI want to point out that Cloudinary will also one-up this This has the benefit to reset the If a browser doesn't support If a browser does support |
The fix is available in [email protected] 🎉 Please give it a try and let us know if it solves your problem with a 👍 or 👎 If you leave a 👎 , please explain why it doesn't work for you and provide steps to reproduce the issue. Thanks! |
* [WIP] Add cms notion integration example - index page * Add cover images for pages * Add post page * Remove preview functionality * Add module.exports to security headers documentation (vercel#26466) Without `module.exports`, the provided code won't work if just pasted into `next.config.js` ## Documentation / Examples - [x] Make sure the linting passes * fix: ignore invalid accept-language header (vercel#26476) Fixes vercel#22329 ## Bug - [x] Related issues linked using fixes vercel#22329 - [x] Integration tests added ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. ## Documentation / Examples - [ ] Make sure the linting passes * chore: Add Alex to lint documentation (vercel#26354) This Pull Request adds [Alex](https://alexjs.com/) to our documentation. It catches insensitive, inconsiderate writing. The original PR (vercel#25821) is too large so I have decided to break it down into smaller PRs. This PR is the first part. Then I will continue to add the rest of the documentation in smaller PRs. ## More Information on Alex: https://alexjs.com/ https://github.com/get-alex/alex ## Documentation / Examples - [x] Make sure the linting passes * Fix domain locales not available on client (vercel#26083) * bug: Fix domain locales not available on client * Add test case * update tests Co-authored-by: JJ Kasper <[email protected]> * Update to only add image import types when enabled (vercel#26485) * Update to only add image import types when enabled * add type check to test * Update i18n fields in docs (vercel#26492) Closes: vercel#24991 ## Documentation / Examples - [x] Make sure the linting passes * v11.0.1-canary.7 * Strongly type `Router.events.on` and `Router.events.off` (vercel#26456) This strongly types `Router.events.on` and `Router.events.off`. Previously the event type was `string` but now it's `'routeChangeStart' | 'beforeHistoryChange' | 'routeChangeComplete' | 'routeChangeError' | 'hashChangeStart' | 'hashChangeComplete'` ## Bug - ~[ ] Related issues linked using `fixes #number`~ - [x] Integration tests added Closes vercel#25679 Closes vercel#23753 Closes vercel#15497 * Update next Link & Image components * Ensure image-types file is included (vercel#26495) * Update react & react-dom to v17 * Update tailwind to use jit * v11.0.1-canary.8 * v11.0.1 * Don't test image domains in test env (vercel#26502) fixes vercel#21549 Co-authored-by: JJ Kasper <[email protected]> * docs: updated minimum Node.js version (vercel#26528) ## Documentation / Examples - [x] Make sure the linting passes According to new requirements in `package.json` minimum Node.js version for now is 12.0 * Update next-env note in docs (vercel#26536) This ensures we don't recommend editing the `next-env` file since we need to be able to tweak it to accept future types we add in Next.js ## Documentation / Examples - [x] Make sure the linting passes Closes: vercel#26533 * [examples] Fix ssr-caching example. (vercel#26540) Closes vercel#12019 with a better example of proper SSR caching. * Fix props not updating when changing the locale and keeping hash (vercel#26205) Currently, there is only a `hashChangeStart` and subsequent `hashChangeComplete` event and no props update (which would be used to get translations, etc.). Happy for any feedback fixes vercel#23467 ## Bug - [x] Related issues linked using `fixes #number` - [x] Integration tests added ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. ## Documentation / Examples - [ ] Make sure the linting passes * Add note about adding additional types (vercel#26545) * Add note about adding additional types * Update to bold edit also * Apply suggestions from code review Co-authored-by: Steven <[email protected]> * Allow user to override next-image-loader (vercel#26548) In PR vercel#26281, we solved one use case but broke another. This PR will allow the user to [override the built-in loader](vercel#26281 (comment)) via custom webpack config. * v11.0.2-canary.0 * chore: Enable Alex documentation linting for error pages (vercel#26526) * Update SWR example to include fetcher function. (vercel#26520) * Previous example doesn't work * Apply suggestions from code review * Update docs/basic-features/data-fetching.md * lint-fix Co-authored-by: Lee Robinson <[email protected]> Co-authored-by: JJ Kasper <[email protected]> * tailwind examps upgraded to v2.2 (vercel#26549) ## Documentation / Examples - [x] Make sure the linting passes * doc: prettify docs for next script (vercel#26572) x-ref: vercel#26518 (comment) ## Documentation / Examples - [x] Make sure the linting passes * Add logging when a custom babelrc is loaded (vercel#26570) Partially solves vercel#26539 by adding back the log output when a config file is used ## Bug - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. ## Documentation / Examples - [ ] Make sure the linting passes * Add comment to not edit in next-env file (vercel#26573) This adds a comment to the generated `next-env.d.ts` to mention it should not be edited pointing to the documentation which contains an example of adding custom types separately. x-ref: vercel#26560 ## Documentation / Examples - [x] Make sure the linting passes * Separate node polyfill test from basic suite (vercel#26550) * Separate node polyfill test from basic suite * update test * fix with-loading example for next 11 (vercel#26569) ## Documentation / Examples - [X] Make sure the linting passes This PR updates the with-loading example to follow the documentation of router events for next 11 * v11.0.2-canary.1 * Add trace url on bootup (vercel#26594) * Add trace url on bootup * Update whitelist -> accesslist * Add name to webpack-invalidated * v11.0.2-canary.2 * Add check for ObjectExpression when iterating on <link> tags for font optimization (vercel#26608) Fixes vercel#26547 ## Bug - [x] Related issues linked using `fixes #number` - [x] Integration tests added ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. ## Documentation / Examples - [ ] Make sure the linting passes * Enable Alex documentation linting for docs (vercel#26598) * Add link to live demo already hosted (vercel#25718) * Add link to live demo already hosted To make it easier for people to simply see the live example without having to deploy a whole new project * update link Co-authored-by: JJ Kasper <[email protected]> * Update next/image docs for relative parent with layout=fill. (vercel#26615) vercel#18739 (reply in thread) * Fix GSP redirect cache error (vercel#26627) This makes sure we don't attempt flushing cache info to disk for `getStaticProps` `redirect` items with `revalidate` Fixes: vercel#20816 ## Bug - [x] Related issues linked using `fixes #number` - [x] Integration tests added * Correct statusCode when visiting _error directly (vercel#26610) This fixes non-stop reloading when visiting `_error` directly in development caused by the `statusCode` being 200 unexpectedly while HMR returns the page as `invalid` which triggers `on-demand-entries` to reload the page. ## Bug - [x] Related issues linked using `fixes #number` - [x] Integration tests added Fixes: vercel#8036 x-ref: vercel#8033 * fix: next dynamic with jest (vercel#26614) Fixes vercel#19862 Avoid executing `webpack` property on `loadableGenerated` of loadable component compiled from `next/dynamic` when `require.resolveWeak` is unavailable due to jest runtime missing `require.resolveWeak`. ## Bug - [x] Related issues linked using `fixes #number` - [x] unit tests added * Ensure API routes are not available under the locale (vercel#26629) This ensures API routes are not available under the locale path since API routes don't need to be localized and we don't provide the locale to the API in any way currently so the user wouldn't be aware if the localized API route was visited instead of the non-localized. Fixes: vercel#25790 ## Bug - [x] Related issues linked using `fixes #number` - [x] Integration tests added * v11.0.2-canary.3 * Fix image content type octet stream 400 (vercel#26705) Fixes vercel#23523 by adding image content type detection ## Bug - [x] Related issues linked using `fixes #number` - [x] Integration tests added * Update layouts example to persist state across client-side transitions. (vercel#26706) * Update layouts example * Update examples/layout-component/components/layout.js Co-authored-by: JJ Kasper <[email protected]> * Fix typo on "occured" to "occurred" (vercel#26709) * fix: typo occured -> occurred * fix: typo occured -> occurred * fix: typo occured -> occurred * fix: typo occured -> occurred * lint-fix Co-authored-by: JJ Kasper <[email protected]> * [ESLint] Adds --max-warnings flag to `next lint` (vercel#26697) Adds `--max-warnings` flag to `next lint` to enable setting of a maximum warning threshold. Fixes vercel#26671 * update with-redux-toolkit-typescript (vercel#26714) ## Bug - [X] Related issues linked using `fixes vercel#26713 ` ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. ## Documentation / Examples - [X] Make sure the linting passes ## Screenshots After this small change the warning disappears. ![image](https://user-images.githubusercontent.com/47717492/123749377-fd56fb80-d8d2-11eb-8b70-dbb7f6f16050.png) * Simplify `next-dev-server` implementation (vercel#26230) `next-dev-server` having its own implementations of `renderToHTML` and `renderErrorToHTML` has historically made reasoning about streaming hard, as it adds additional places where status codes are explicitly set and the full HTML is blocked on. Instead, this PR simplifies things considerably by moving the majority of the custom logic for e.g. hot reloading and on-demand compilation to when we're resolving the page to be loaded, rather than upfront when handling the request. It also cleans up a few other details (e.g. default error page rendering) that managed to creep into the base implementation over time. One unfortunate side effect is that this makes compilation errors slightly more difficult. Previously, we'd render them directly. Now, we have to rethrow them. But since they've already been logged (by the watch pipeline), we have to make sure they don't get logged again. * Update PR labeler action * Simplify stats action (vercel#26751) * Move code shared between server/client to "shared" folder (vercel#26734) * Move next-server directory files to server directory (vercel#26756) * Move next-server directory files to server directory * Update tests * Update paths in other places * Support new hydrate API in latest react 18 alpha release (vercel#26664) * fix: react 18 new hydration API * support react 18 * compat latest react only, fix resolved version * fix tests * Some changes based on reactwg/react-18#5 * fix test Co-authored-by: Tim Neutkens <[email protected]> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> * Disable build-output size specific tests (vercel#26769) * Disable build-output size specific tests * remove size-limit test * lint-fix * Add upstream `max-age` to optimized image (vercel#26739) This solves the main use case from Issue vercel#19914. Previously, we would set the `Cache-Control` header to a constant and rely on the server cache. This would mean the browser would always request the image and the server could response with 304 Not Modified to omit the response body. This PR changes the behavior such that the `max-age` will propagate from the upstream server to the Next.js Image Optimization Server and allow browser caching. ("upstream" meaning external server or just an internal route to an image) This PR does not change the `max-age` for static imports which will remain `public, max-age=315360000, immutable`. #### Pros: - Fewer HTTP requests after initial browser visit - User configurable `max-age` via the upstream image `Cache-Control` header #### Cons: - ~~Might be annoying for `next dev` when modifying a source image~~ (solved: use `max-age=0` for dev) - Might cause browser to cache longer than expected (up to 2x longer than the server cache if requested in the last second before expiration) ## Bug - [x] Related issues linked using `fixes #number` * Fix blurred image position when using objectPosition (vercel#26590) ## Bug fixes vercel#26309 ## Documentation / Examples see vercel#26309 - [ ] Make sure the linting passes * Update azure tests (vercel#26779) * Stabilize relay-analytics test (vercel#26782) * Leverage blocked page for _error (vercel#26748) ## Enhance simplify detection for visiting `_error` x-ref: vercel#26610 * Update codeowners to add new maintainers (vercel#26770) * examples: fix typo `lunix` → `linux` (vercel#26796) ## Bug - [ ] ~~Related issues linked using `fixes #number`~~ - [ ] ~~Integration tests added~~ ## Feature - [ ] ~~Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.~~ - [ ] ~~Related issues linked using `fixes #number`~~ - [ ] ~~Integration tests added~~ - [ ] ~~Documentation added~~ - [ ] ~~Telemetry added. In case of a feature if it's used or not.~~ ## Documentation / Examples - [x] Make sure the linting passes * Update repo scripts to separate folder (vercel#26787) * fix: detect loop in client error page (vercel#26567) Co-authored-by: Tobias Koppers <[email protected]> Co-authored-by: Tim Neutkens <[email protected]> * Update snapshot for font-optimization test (vercel#26823) This fixes the `font-optimization` test failing from the links/content changing slightly in the snapshot. ## Bug - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. ## Documentation / Examples - [ ] Make sure the linting passes * Add `onLoadingComplete()` prop to Image component (vercel#26824) This adds a new prop, `onLoadingComplete()`, to handle the most common use case of `ref`. I also added docs and a warning when using `ref` so we recommend the new prop instead. - Fixes vercel#18398 - Fixes vercel#22482 * Add "Vary: Accept" header to /_next/image responses (vercel#26788) This pull request adds "Vary: Accept" header to responses from the image optimizer (i.e. the /_next/image endpoint). The image optimizer prefers re-encoding JPG files to WebP, but some browsers (such as Safari 14 on Catalina) do not yet support WebP. In such cases the optimizer uses the Accept header sent by the browser to send out a JPG response. Thus the optimizer's response may depend on the Accept header. Potential caching proxies can be informed of this fact by adding "Vary: Accept" to the response headers. Otherwise WebP data may be served to browsers that do not support it, for example in the following scenario: * A browser that supports WebP requests the JPG. The optimizer re-encodes it to WebP. The proxy caches the WebP data. * After this another browser that doesn't support WebP requests the JPG. The proxy sends the WebP data to the browser. - [x] Integration tests added - [x] Make sure the linting passes * Fix using-preact example deps (vercel#26821) Fix after vercel#26133 * Add additional tests for image type detection (vercel#26832) Adding additional tests. Follow up to vercel#26705 * Fix immutable header for image with static import & unoptimized (vercel#26836) Fixes vercel#26587 * Update `publish-canary` script to include checkout (vercel#26840) * Update `publish-canary` script to include checkout * Update contrib with publishing section * v11.0.2-canary.4 * Make sure 404 pages do not get cached by a CDN when using next start (vercel#24983) Co-authored-by: Jiachi Liu <[email protected]> Co-authored-by: JJ Kasper <[email protected]> * Update to environment-variable.md (vercel#26863) ## Bug - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [x] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. ## Documentation / Examples - [ ] Make sure the linting passes ## Why the change I lost quite a few hours figuring out why my environment variable was `undefined` in the browser. I read about the built-in support and was like: "Oh nice" and didn't read much further. I missed the part about how you need to prefix your variables with `NEXT_PUBLIC_` in order to expose them to the browser. I think a hint to this in the anchor link to that section will make it more discoverable as it's then mentioned near the top and will save people who are like me some time and a headache. * Don't emit duplicate image files (vercel#26843) fixes vercel#26607 This change makes it so the image loader plugin only emits a file while processing an image import for the client. The final generated image URL was already the same in SSR and CSR anyway, so this change doesn't have any functional impact. I also changed the name of the static page in the image component tests, since it was causing some conflicts with the static assets folder. * Add instructions on how to add nextjs.org/docs/messages urls (vercel#26865) Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> * Rename example folder to with-notion * Update references of example * Reorder docs manifest and rename to Script Optimization. (vercel#26874) So there's _conformance_ between the other docs / optimizations. * Fix typo on "occured" to "occurred" (vercel#26876) - Fix typo on "occured" to "occurred" * Update README Co-authored-by: Sam Robbins <[email protected]> Co-authored-by: Jiachi Liu <[email protected]> Co-authored-by: Peter Mekhaeil <[email protected]> Co-authored-by: Rob Vermeer <[email protected]> Co-authored-by: JJ Kasper <[email protected]> Co-authored-by: Brandon Bayer <[email protected]> Co-authored-by: Alex Castle <[email protected]> Co-authored-by: Vitaly Baev <[email protected]> Co-authored-by: Lee Robinson <[email protected]> Co-authored-by: destruc7i0n <[email protected]> Co-authored-by: Steven <[email protected]> Co-authored-by: Joshua Byrd <[email protected]> Co-authored-by: Pranav P <[email protected]> Co-authored-by: Tim Neutkens <[email protected]> Co-authored-by: John <[email protected]> Co-authored-by: Tim Neutkens <[email protected]> Co-authored-by: Vadorequest <[email protected]> Co-authored-by: hiro <[email protected]> Co-authored-by: Houssein Djirdeh <[email protected]> Co-authored-by: Soham Shah <[email protected]> Co-authored-by: Gerald Monaco <[email protected]> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> Co-authored-by: Nils Schönwald <[email protected]> Co-authored-by: D. Kasi Pavan Kumar <[email protected]> Co-authored-by: Tobias Koppers <[email protected]> Co-authored-by: Joachim Viide <[email protected]> Co-authored-by: Artur Sedlukha <[email protected]> Co-authored-by: Paul van den Dool <[email protected]> Co-authored-by: hiro <[email protected]>
- Closes #23328 - Related to #19914 - Related to #22319 ## Feature - [x] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [x] Related issues linked using `fixes #number` - [x] Integration tests added - [x] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. - [x] Errors have helpful link attached, see `contributing.md`
Looks like we have 4 thumbs up and 0 thumbs down on the latest canary release after 2 weeks so I'm going to close this issue. See my previous comment for more details. Also, I created #27208 to track the the stale-while-revalidate feature request. Thanks! |
In a previous PR (#27200), we added `minimumCacheTTL` to configure the time-to-live for the cached image. However, this was setting the `max-age` header. This PR ensures that `minimumCacheTTL` doesn't affect browser caching, only the upstream header can affect browser caching. This is a bit safer in case the developer accidentally caches something that shouldn't be and the cache needs to be invalidated. Simply delete the `.next/cache/images` directory. - Related to #19914 - Related to #22319
This solves the main use case from Issue vercel#19914. Previously, we would set the `Cache-Control` header to a constant and rely on the server cache. This would mean the browser would always request the image and the server could response with 304 Not Modified to omit the response body. This PR changes the behavior such that the `max-age` will propagate from the upstream server to the Next.js Image Optimization Server and allow browser caching. ("upstream" meaning external server or just an internal route to an image) This PR does not change the `max-age` for static imports which will remain `public, max-age=315360000, immutable`. #### Pros: - Fewer HTTP requests after initial browser visit - User configurable `max-age` via the upstream image `Cache-Control` header #### Cons: - ~~Might be annoying for `next dev` when modifying a source image~~ (solved: use `max-age=0` for dev) - Might cause browser to cache longer than expected (up to 2x longer than the server cache if requested in the last second before expiration) ## Bug - [x] Related issues linked using `fixes #number`
- Closes vercel#23328 - Related to vercel#19914 - Related to vercel#22319 ## Feature - [x] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [x] Related issues linked using `fixes #number` - [x] Integration tests added - [x] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. - [x] Errors have helpful link attached, see `contributing.md`
) In a previous PR (vercel#27200), we added `minimumCacheTTL` to configure the time-to-live for the cached image. However, this was setting the `max-age` header. This PR ensures that `minimumCacheTTL` doesn't affect browser caching, only the upstream header can affect browser caching. This is a bit safer in case the developer accidentally caches something that shouldn't be and the cache needs to be invalidated. Simply delete the `.next/cache/images` directory. - Related to vercel#19914 - Related to vercel#22319
This issue has been automatically locked due to no recent activity. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you. |
Bug report
Describe the bug
When requesting
/_next/image(.*)
, I'm getting this Response header:And it's fine... What's not fine is that I'm getting the same exact Response headers even when I use custom headers in
next.config.js
, i.e.:To Reproduce
Try this
next.config.js
above, with an image that uses common<img>
tag like this:And another tag that uses the new
next/image
component, with the same or whatever image url, for example:And try requesting those images in the browser, and look into
Devtools -> Network
tab, the Response headers, and see that for common<img>
tag it's actually changed, whereas for new<Image>
component it is not.Expected behavior
For
/_next/image(.*)
urls, I expected to see Headers that I setup, i.e.Cache-Control: public, max-age=180, s-maxage=180, stale-while-revalidate=180
.Screenshots
Common
<img>
:New
<Image>
:System information
next start
on development machine, and actual Vercel deployment (screenshots demonstrate the case with local machine, but I've confirmed that the same is happening on a Vercel deployment)Additional context
Originally I created an issue using "Feature request" template, and it got translated into "Idea discussion": #19896 (how to delete/close it pls? doesn't seem to be possible), - initially I wasn't sure if it's even possible to setup custom headers, and how that supposed to work, though I just needed that functionality. But later, upon discovering that there's such a functionality already, I figured out that actually
/_next/image
overrides both custom headers innext.config.js
and headers property of Vercel config, i.e. it's not just some idea of a feature that is "not implemented", but it's actual bug.The text was updated successfully, but these errors were encountered: