-
Notifications
You must be signed in to change notification settings - Fork 27.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
getStaticPaths with fallback: false, return 404 page for non-ASCII/non-Latin url #17642
Milestone
Comments
same issue |
Maybe same as #10084 |
This comment has been minimized.
This comment has been minimized.
kodiakhq bot
pushed a commit
that referenced
this issue
Dec 28, 2020
…19135) This ensures we handle encoding/decoding for SSG prerendered/fallback pages correctly. Since we only encode path delimiters when outputting to the disk we need to match this encoding when building the `ssgCacheKey` to look-up the prerendered pages. This also fixes non-ascii prerendered paths (e.g. 商業日語) not matching correctly. This does not resolve 👉 #10084 and further investigation will be needed before addressing non-ascii paths for non-SSG pages. The encoding output was tested against https://tst-encoding-l7amu5b9c.vercel.app/ to ensure the values will match correctly on Vercel. Closes: #17582 Closes: #17642 x-ref: #14717
Hi, this has been updated in |
This issue has been automatically locked due to no recent activity. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Bug report
Describe the bug
In the following page called
pages/a/[slug]/index.js
The value of
slug
is dynamic value that can be ASCII or Non-ASCII characters, So, When navigate to url of ASCII(Synonyms)
, Page rendered correctly but for Non-ASCII(อักษรย่อ)
, I got 404 page.List of urls:
อักษรย่อ
Url:
/a/อักษรย่อ
encodeURIComponent:
/a/%E0%B8%AD%E0%B8%B1%E0%B8%81%E0%B8%A9%E0%B8%A3%E0%B8%A2%E0%B9%88%E0%B8%AD
Synonyms
Url:
/a/Synonyms
encodeURIComponent:
/a/Synonyms
To Reproduce
Steps to reproduce the behavior, please provide code snippets or a repository:
Expected behavior
Should return correctly of url path and param for all encoding in
fallback: false
mode.Screenshots
Page of non-ascii url:
Page of ascii url:
Result from
build
commandFiles from
build
command in.next
folder:System information
Additional context
OSX is got same behavior and 404 page. So, Path syntax is not root cause for this case for sure.
The text was updated successfully, but these errors were encountered: