Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Development server reports boot too early #15928

Closed
Timer opened this issue Aug 6, 2020 · 1 comment · Fixed by #15929
Closed

Development server reports boot too early #15928

Timer opened this issue Aug 6, 2020 · 1 comment · Fixed by #15929
Assignees
@Timer
Milestone
iteration 6

Comments

@Timer
Copy link
Member

Timer commented Aug 6, 2020

Bug report

Describe the bug

❯ yarn next dev examples/z-experimental-refresh/
yarn run v1.22.4
$ node --trace-deprecation packages/next/dist/bin/next dev examples/z-experimental-refresh/
ready - started server on http://localhost:3000
Port 3000 is already in use.
Use `npm run dev -- -p <some other port>`.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

To Reproduce

Run a Next.js app on a port that is already in use.

Expected behavior

❯ yarn next dev examples/z-experimental-refresh/                                                                                                                                     ✘ 1 
yarn run v1.22.4
$ node --trace-deprecation packages/next/dist/bin/next dev examples/z-experimental-refresh/
Port 3000 is already in use.
Use `npm run dev -- -p <some other port>`.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
@Timer Timer added the kind: bug label Aug 6, 2020
@Timer Timer self-assigned this Aug 6, 2020
@Timer Timer mentioned this issue Aug 6, 2020
Merged
@kodiakhq kodiakhq bot closed this as completed in #15929 Aug 6, 2020
kodiakhq bot pushed a commit that referenced this issue Aug 6, 2020
@Timer
Delay server start message until it's listening (#15929)
2d42b8e 
Fixes #15928

---

This would cause us to print the message too early and open the browser to a server that wasn't started yet. This waits until we're listening, but before the app is ready fully.
@Timer Timer added this to the iteration 6 milestone Aug 6, 2020
@balazsorban44
Copy link
Member

This issue has been automatically locked due to no recent activity. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

@vercel vercel locked as resolved and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Timer Timer

Labels
None yet
Projects
None yet
Milestone
iteration 6
Development

Successfully merging a pull request may close this issue.

Delay server start message until it's listening Timer/next.js
2 participants
@Timer @balazsorban44