Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paths with dynamic routing params still not case-sensitive #15377

Closed
tsvetta opened this issue Jul 21, 2020 · 1 comment · Fixed by #15444
Closed

Paths with dynamic routing params still not case-sensitive #15377

tsvetta opened this issue Jul 21, 2020 · 1 comment · Fixed by #15444
Labels
good first issue Easy to fix issues, good for newcomers
Milestone

Comments

@tsvetta
Copy link

tsvetta commented Jul 21, 2020

Bug report

Describe the bug

The part of URL that goes after dynamic param (like [slug]) are still not case-sensitive.

To Reproduce

  1. Create an empty next app
  2. Create a page with dynamic parameter like: pages/dynamic/[slug]/route.js
  3. Try to go to a route with upper-case letters like /dynamic/hello-there/RoUtE
  4. The same page will be loaded as in the route /dynamic/hello-there/route

Also, I forked this repo and tried to write some tests, you can look at them here: #15394

I will be happy to read any advices.

Expected behavior

The part of the url that goes after dynamic param should also be case-sensitive and should send 404 page when try to load it.

System information

  • OS: [e.g. macOS, Windows]
  • Browser: chrome
  • Version of Next.js: v9.4.5-canary.42
  • Version of Node.js: 10.16.3

Additional context

Relates to #8848

@timneutkens timneutkens added good first issue Easy to fix issues, good for newcomers kind: bug labels Jul 23, 2020
@timneutkens timneutkens added this to the backlog milestone Jul 23, 2020
@kodiakhq kodiakhq bot closed this as completed in #15444 Jul 25, 2020
kodiakhq bot pushed a commit that referenced this issue Jul 25, 2020
@Timer Timer modified the milestones: backlog, iteration 5 Jul 25, 2020
@balazsorban44
Copy link
Member

This issue has been automatically locked due to no recent activity. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

@vercel vercel locked as resolved and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Easy to fix issues, good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants