Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect basePath in amphtml link rel #15244

Closed
amiralies opened this issue Jul 17, 2020 · 4 comments · Fixed by #15949
Closed

Respect basePath in amphtml link rel #15244

amiralies opened this issue Jul 17, 2020 · 4 comments · Fixed by #15949
Labels
good first issue Easy to fix issues, good for newcomers
Milestone

Comments

@amiralies
Copy link
Contributor

When using basePath in next config amphtml link rel doesn't respect basePath.
Note that this might be already fixed since i'm using experimental basePath in latest release (9.4.4)

@jamesmosier
Copy link
Contributor

Hi @amiralies 👋 Two good first steps to help out in tracking this down:

1.) Update your project to the latest canary: npm install next@canary (or yarn add next@canary)
2.) Include a full reproduction in a repository.

@jamesmosier jamesmosier added the please add a complete reproduction Please add a complete reproduction. label Jul 17, 2020
@timneutkens
Copy link
Member

I doubt this was covered yet. Should be simple to fix though

@timneutkens timneutkens added good first issue Easy to fix issues, good for newcomers and removed please add a complete reproduction Please add a complete reproduction. labels Jul 17, 2020
@amiralies
Copy link
Contributor Author

I think this can be fixed in next/next-server/server/config.ts.
if amp.canonicalBase is empty and basePath is not empty then assign basePath's value to amp.canonicalBase. similar scenario is happening for assetPrefix.
correct me if i'm wrong.

amiralies added a commit to amiralies/next.js that referenced this issue Aug 6, 2020
@Timer Timer added this to the iteration 6 milestone Aug 8, 2020
@balazsorban44
Copy link
Member

This issue has been automatically locked due to no recent activity. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

@vercel vercel locked as resolved and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Easy to fix issues, good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants