Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trailing slash redirect with basepath #14757

Closed
Janpot opened this issue Jul 1, 2020 · 3 comments · Fixed by #14781
Closed

Trailing slash redirect with basepath #14757

Janpot opened this issue Jul 1, 2020 · 3 comments · Fixed by #14781
Assignees
@Janpot
Milestone
iteration 5

Comments

@Janpot
Copy link
Contributor

Janpot commented Jul 1, 2020 •
edited
Loading

Bug report

Describe the bug

Redirecting trailing slash to non-trailing slash url seems to strip the basepath twice

To Reproduce

  1. yarn next build test/integration/basepath && yarn next start test/integration/basepath
  2. Visit http://localhost:3000/docs/hello/
  3. Browser redirects to /hello, then there seems to be a history replace to /docso

Expected behavior

Redirects to http://localhost:3000/docs/hello
@Janpot Janpot self-assigned this Jul 1, 2020
@Timer Timer added this to the iteration 4 milestone Jul 1, 2020
@Timer
Copy link
Member

Timer commented Jul 10, 2020

👀 was there a PR opened for this? I thought there was.

@Janpot
Copy link
Contributor Author

Janpot commented Jul 10, 2020 •
edited
Loading

I started on it, but it stalled on deciding how basepath+redirect should work: #14781
There's also a corner case with the root path that I need to look into.

@Janpot Janpot mentioned this issue Jul 10, 2020
Merged
@Timer Timer modified the milestones: iteration 4, iteration 5 Jul 13, 2020
@kodiakhq kodiakhq bot closed this as completed in #14781 Jul 13, 2020
kodiakhq bot pushed a commit that referenced this issue Jul 13, 2020
@Janpot
Trailing slash basepath (#14781)
d2699be 
Fixes #14757

Since #15041 has been sorted out, this can now be fully fixed
There was also a bug in the dev server that causes redirect loops
@balazsorban44
Copy link
Member

This issue has been automatically locked due to no recent activity. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

@vercel vercel locked as resolved and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Janpot Janpot

Labels
None yet
Projects
None yet
Milestone
iteration 5
Development

Successfully merging a pull request may close this issue.

Trailing slash basepath Janpot/next.js
3 participants
@Timer @Janpot @balazsorban44