Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fast refresh not working when page has exported config #13978

Closed
amiralies opened this issue Jun 9, 2020 · 1 comment · Fixed by #14041
Closed

Fast refresh not working when page has exported config #13978

amiralies opened this issue Jun 9, 2020 · 1 comment · Fixed by #14041
Assignees
@Timer
Milestone
june 2020

Comments

@amiralies
Copy link
Contributor

Bug report

Fast refresh not working when exporting page config. (hybrid amp pages)

export const config = { amp: 'hybrid' };

To Reproduce

Add the line above to a fast reresh enabled page

Expected behavior

Fast refresh should work on react version of page (no amp).

System information

  • OS: Linux
  • Browse: Chromium 83 Arch Linux
  • Version of Next.js: 9.4.0
  • Version of Node.js: 12.17

Additional context

related #13104
@Timer Timer added the kind: bug label Jun 9, 2020
@Timer Timer self-assigned this Jun 9, 2020
@Timer Timer added this to the june 2020 milestone Jun 9, 2020
@Timer Timer mentioned this issue Jun 10, 2020
Merged
@kodiakhq kodiakhq bot closed this as completed in #14041 Jun 10, 2020
kodiakhq bot pushed a commit that referenced this issue Jun 10, 2020
@Timer
Fix Fast Refresh with Page Config (#14041)
80036fd 
Fixes #13978
darshkpatel pushed a commit to MLH-Fellowship/next.js that referenced this issue Jun 12, 2020
@Timer @darshkpatel
Fix Fast Refresh with Page Config (vercel#14041)
97dd692 
Fixes vercel#13978
rokinsky pushed a commit to rokinsky/next.js that referenced this issue Jul 11, 2020
@Timer @rokinsky
Fix Fast Refresh with Page Config (vercel#14041)
5765aa5 
Fixes vercel#13978
@balazsorban44
Copy link
Member

This issue has been automatically locked due to no recent activity. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

@vercel vercel locked as resolved and limited conversation to collaborators Jan 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Timer Timer

Labels
None yet
Projects
None yet
Milestone
june 2020
Development

Successfully merging a pull request may close this issue.

Fix Fast Refresh with Page Config Timer/next.js
3 participants
@Timer @amiralies @balazsorban44