Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow React Profiling in production through reactProductionProfiling: true in next.config.js #13709

Closed
timneutkens opened this issue Jun 3, 2020 · 2 comments · Fixed by #13873
Closed

Allow React Profiling in production through reactProductionProfiling: true in next.config.js #13709

timneutkens opened this issue Jun 3, 2020 · 2 comments · Fixed by #13873
Labels
good first issue Easy to fix issues, good for newcomers
Milestone
iteration 3

Comments

@timneutkens
Copy link
Member

Feature request

Is your feature request related to a problem? Please describe.

Currently you have to edit the Next.js webpack configuration to make the React Profiler work in production. Similar to https://gist.github.com/bvaughn/25e6233aeb1b4f0cdb8d8366e54a3977#webpack-4.

Describe the solution you'd like

Introduce a new flag in next.config.js similar to reactStrictMode that allows users to opt-in to the profiling bundle (configures https://gist.github.com/bvaughn/25e6233aeb1b4f0cdb8d8366e54a3977#webpack-4 automatically)
@timneutkens timneutkens added good first issue Easy to fix issues, good for newcomers Type: Feature Request labels Jun 3, 2020
@todortotev
Copy link
Contributor

Starting work on it 💪 🔥

@Timer Timer removed the help wanted label Jun 3, 2020
This was referenced Jun 4, 2020
Closed
Merged
@Timer Timer added this to the iteration 3 milestone Jun 17, 2020
@kodiakhq kodiakhq bot closed this as completed in #13873 Jun 28, 2020
kodiakhq bot pushed a commit that referenced this issue Jun 28, 2020
@todortotev
Introduce react profiling production flag (#13873)
1aed9ea 
Closes [13709](#13709).

The solution works, **(tested and confirmed with true and false flags with the latest next version)** though I am quite sure this is not the most elegant and proper way to implement it. I have spent the good part of yesterday and today's morning in order to make it more generic but since it's my first time working with anything related to webpack I have struggled miserably. Last, but not least I'm unsure if this is the most proper naming for the flag.

Please, let me know what you want me to change and I'll get it done asap.
rokinsky pushed a commit to rokinsky/next.js that referenced this issue Jul 11, 2020
@todortotev @rokinsky
Introduce react profiling production flag (vercel#13873)
7fe8fc3 
Closes [13709](vercel#13709).

The solution works, **(tested and confirmed with true and false flags with the latest next version)** though I am quite sure this is not the most elegant and proper way to implement it. I have spent the good part of yesterday and today's morning in order to make it more generic but since it's my first time working with anything related to webpack I have struggled miserably. Last, but not least I'm unsure if this is the most proper naming for the flag.

Please, let me know what you want me to change and I'll get it done asap.
@balazsorban44
Copy link
Member

This issue has been automatically locked due to no recent activity. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

@vercel vercel locked as resolved and limited conversation to collaborators Jan 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
good first issue Easy to fix issues, good for newcomers
Projects
None yet
Milestone
iteration 3
Development

Successfully merging a pull request may close this issue.

Introduce react profiling production flag
Introduce react profiling production flag
4 participants
@Timer @timneutkens @balazsorban44 @todortotev