Polish error icon for error log (#55618)

### After 💅 <img width="109" alt="image" src="https://github.com/vercel/next.js/assets/4800338/f90d15a1-ac6e-4fe1-8241-d9e40e9d2e0e"> ### Before <img width="143" alt="image" src="https://github.com/vercel/next.js/assets/4800338/fbc09a29-cac2-459d-8a96-d1a5948947cc">
vercel · Sep 20, 2023 · f5bef04 · f5bef04
1 parent 23c3ea4
commit f5bef04
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 21 deletions.
diff --git a/packages/next/src/build/output/log.ts b/packages/next/src/build/output/log.ts
@@ -2,7 +2,7 @@ import chalk from '../../lib/chalk'
 
 export const prefixes = {
   wait: chalk.white(chalk.bold('○')),
-  error: chalk.red(chalk.bold('X')),
+  error: chalk.red(chalk.bold('⨯')),
   warn: chalk.yellow(chalk.bold('⚠')),
   ready: chalk.bold('▲'), // no color
   info: chalk.white(chalk.bold(' ')),

diff --git a/test/development/middleware-errors/index.test.ts b/test/development/middleware-errors/index.test.ts
@@ -29,13 +29,13 @@ createNextDescribe(
       it('logs the error correctly', async () => {
         await next.fetch('/')
         const output = stripAnsi(next.cliOutput)
-        await check(
-          () => stripAnsi(next.cliOutput),
-          new RegExp(
-            `middleware.js \\(\\d+:\\d+\\) @ Object.default \\[as handler\\]\\s*\\w+\\s*boom`,
-            'm'
+        await check(() => {
+          expect(stripAnsi(next.cliOutput)).toMatch(
+            /middleware.js \(\d+:\d+\) @ Object.default \[as handler\]/
           )
-        )
+          expect(stripAnsi(next.cliOutput)).toMatch(/boom/)
+          return 'success'
+        }, 'success')
         expect(output).not.toContain(
           'webpack-internal:///(middleware)/./middleware.js'
         )
@@ -103,13 +103,13 @@ createNextDescribe(
       it('logs the error correctly', async () => {
         await next.fetch('/')
         const output = stripAnsi(next.cliOutput)
-        await check(
-          () => stripAnsi(next.cliOutput),
-          new RegExp(
-            `middleware.js \\(\\d+:\\d+\\) @ eval\\s*\\w+\\s*test is not defined`,
-            'm'
+        await check(() => {
+          expect(stripAnsi(next.cliOutput)).toMatch(
+            /middleware.js \(\d+:\d+\) @ eval/
           )
-        )
+          expect(stripAnsi(next.cliOutput)).toMatch(/test is not defined/)
+          return 'success'
+        }, 'success')
         expect(output).not.toContain(
           'webpack-internal:///(middleware)/./middleware.js'
         )
@@ -141,13 +141,13 @@ createNextDescribe(
       it('logs the error correctly', async () => {
         await next.fetch('/')
         const output = stripAnsi(next.cliOutput)
-        await check(
-          () => stripAnsi(next.cliOutput),
-          new RegExp(
-            `middleware.js \\(\\d+:\\d+\\) @ <unknown>\\s*\\w+\\s*booooom!`,
-            'm'
+        await check(() => {
+          expect(stripAnsi(next.cliOutput)).toMatch(
+            /middleware.js \(\d+:\d+\) @ <unknown>/
           )
-        )
+          expect(stripAnsi(next.cliOutput)).toMatch(/booooom!/)
+          return 'success'
+        }, 'success')
         expect(output).not.toContain(
           'webpack-internal:///(middleware)/./middleware.js'
         )
@@ -247,8 +247,14 @@ createNextDescribe(
 
       it('logs the error correctly', async () => {
         await next.fetch('/')
-        expect(next.cliOutput).toContain(`Expected '{', got '}'`)
-        expect(next.cliOutput.split(`Expected '{', got '}'`).length).toEqual(2)
+        await check(async () => {
+          expect(next.cliOutput).toContain(`Expected '{', got '}'`)
+          expect(next.cliOutput.split(`Expected '{', got '}'`).length).toEqual(
+            2
+          )
+
+          return 'success'
+        }, 'success')
       })
 
       it('renders the error correctly and recovers', async () => {