Turbopack build: Skip experimental.esmExternals tests

vercel · Jul 18, 2024 · d9c0e6b · d9c0e6b
1 parent 0be0abf
commit d9c0e6b
Show file tree

Hide file tree

Showing 3 changed files with 35 additions and 31 deletions.
diff --git a/docs/04-architecture/turbopack.mdx b/docs/04-architecture/turbopack.mdx
@@ -50,6 +50,8 @@ These features are currently not supported:
   - We are planning to implement this in the future.
 - `experimental.sri.algorithm`
   - We are planning to implement this in the future.
+- `experimental.esmExternals`
+  - We are currently not planning to support the legacy esmExternals configuration in Next.js with Turbopack.
 - [AMP](/docs/pages/building-your-application/configuring/amp).
   - We are currently not planning to support AMP in Next.js with Turbopack.
 - Yarn PnP

diff --git a/test/integration/externals-esm-loose/test/index.test.js b/test/integration/externals-esm-loose/test/index.test.js
@@ -13,36 +13,38 @@ import {
 const appDir = join(__dirname, '../')
 let appPort
 let app
+;(process.env.TURBOPACK ? describe.skip : describe)(
+  "Handle ESM externals with esmExternals: 'loose'",
+  () => {
+    ;(process.env.TURBOPACK_DEV ? describe.skip : describe)(
+      'production mode',
+      () => {
+        beforeAll(async () => {
+          await fs.remove(join(appDir, '.next'))
+          await nextBuild(appDir)
+          appPort = await findPort()
+          app = await nextStart(appDir, appPort)
+        })
+        afterAll(() => killApp(app))
 
-describe("Handle ESM externals with esmExternals: 'loose'", () => {
-  ;(process.env.TURBOPACK_DEV ? describe.skip : describe)(
-    'production mode',
-    () => {
-      beforeAll(async () => {
-        await fs.remove(join(appDir, '.next'))
-        await nextBuild(appDir)
-        appPort = await findPort()
-        app = await nextStart(appDir, appPort)
-      })
-      afterAll(() => killApp(app))
+        const expected =
+          /Hello <!-- -->World<!-- -->\+<!-- -->World<!-- -->\+<!-- -->World/
 
-      const expected =
-        /Hello <!-- -->World<!-- -->\+<!-- -->World<!-- -->\+<!-- -->World/
+        it('should render the static page', async () => {
+          const html = await renderViaHTTP(appPort, '/static')
+          expect(html).toMatch(expected)
+        })
 
-      it('should render the static page', async () => {
-        const html = await renderViaHTTP(appPort, '/static')
-        expect(html).toMatch(expected)
-      })
+        it('should render the ssr page', async () => {
+          const html = await renderViaHTTP(appPort, '/ssr')
+          expect(html).toMatch(expected)
+        })
 
-      it('should render the ssr page', async () => {
-        const html = await renderViaHTTP(appPort, '/ssr')
-        expect(html).toMatch(expected)
-      })
-
-      it('should render the ssg page', async () => {
-        const html = await renderViaHTTP(appPort, '/ssg')
-        expect(html).toMatch(expected)
-      })
-    }
-  )
-})
+        it('should render the ssg page', async () => {
+          const html = await renderViaHTTP(appPort, '/ssg')
+          expect(html).toMatch(expected)
+        })
+      }
+    )
+  }
+)
diff --git a/test/turbopack-build-tests-manifest.json b/test/turbopack-build-tests-manifest.json
@@ -9260,12 +9260,12 @@
     },
     "test/integration/externals-esm-loose/test/index.test.js": {
       "passed": [],
-      "failed": [
+      "failed": [],
+      "pending": [
         "Handle ESM externals with esmExternals: 'loose' production mode should render the ssg page",
         "Handle ESM externals with esmExternals: 'loose' production mode should render the ssr page",
         "Handle ESM externals with esmExternals: 'loose' production mode should render the static page"
       ],
-      "pending": [],
       "flakey": [],
       "runtimeError": false
     },