test: add basic tests for error logs

vercel · Dec 6, 2024 · 9a575b8 · 9a575b8
1 parent fb39f25
commit 9a575b8
Show file tree

Hide file tree

Showing 20 changed files with 435 additions and 89 deletions.
diff --git a/.../error-overlay/callback-timeout-2/page.js → ...wner-stack/app/callback-timeout-2/page.js b/.../error-overlay/callback-timeout-2/page.js → ...wner-stack/app/callback-timeout-2/page.js
@@ -16,7 +16,7 @@ async function Inner() {
 
 async function foo() {
   await setTimeout(0)
-  unstable_after(function aboveBar() {
+  unstable_after(() => {
     return bar()
   })
 }

diff --git a/...pp/error-overlay/callback-timeout/page.js → ...-owner-stack/app/callback-timeout/page.js b/...pp/error-overlay/callback-timeout/page.js → ...-owner-stack/app/callback-timeout/page.js
@@ -10,17 +10,17 @@ function Wrapper() {
 }
 
 function Inner() {
-  bar()
+  foo()
   return null
 }
 
-function bar() {
-  unstable_after(function aboveZap() {
-    return zap()
+function foo() {
+  unstable_after(() => {
+    return bar()
   })
 }
 
-async function zap() {
+async function bar() {
   await setTimeout(0)
   throws()
 }

diff --git a/...ext-after-app/app/error-overlay/layout.js → ...pp-errors/react-owner-stack/app/layout.js b/...ext-after-app/app/error-overlay/layout.js → ...pp-errors/react-owner-stack/app/layout.js
@@ -3,6 +3,9 @@ export const metadata = {
   description: 'Generated by Next.js',
 }
 
+// TODO: check build-time errors if we allow something static
+export const dynamic = 'force-dynamic'
+
 export default function RootLayout({ children }) {
   return (
     <html lang="en">

diff --git a/...pp/error-overlay/nested-promise-2/page.js → ...-owner-stack/app/nested-promise-2/page.js b/...pp/error-overlay/nested-promise-2/page.js → ...-owner-stack/app/nested-promise-2/page.js
@@ -14,12 +14,10 @@ function Inner() {
   return null
 }
 
-// this should bail out, otherwise it'll likely be incorrect
-
-async function foo() {
-  await setTimeout(0)
+function foo() {
   unstable_after(bar())
 }
+
 async function bar() {
   await setTimeout(0)
   unstable_after(zap())

diff --git a/...y/nested-promise-above-callback-1/page.js → ...p/nested-promise-above-callback-1/page.js b/...y/nested-promise-above-callback-1/page.js → ...p/nested-promise-above-callback-1/page.js
diff --git a/.../next-after-app-errors/react-owner-stack/app/nested-promise-above-callback-2-sync/page.js b/.../next-after-app-errors/react-owner-stack/app/nested-promise-above-callback-2-sync/page.js
@@ -0,0 +1,35 @@
+import { unstable_after } from 'next/server'
+import { setTimeout } from 'timers/promises'
+
+export default function Page() {
+  return <Wrapper />
+}
+
+function Wrapper() {
+  return <Inner />
+}
+
+function Inner() {
+  foo()
+  return null
+}
+
+function foo() {
+  unstable_after(bar())
+}
+
+async function bar() {
+  // TODO(after): it looks like `aboveZap` is not in the stack if `zap` does `setTimeout(0)`?
+  unstable_after(function aboveZap() {
+    return zap()
+  })
+}
+
+async function zap() {
+  await setTimeout(0)
+  throws()
+}
+
+function throws() {
+  throw new Error('kaboom')
+}
diff --git a/...y/nested-promise-above-callback-2/page.js → ...p/nested-promise-above-callback-2/page.js b/...y/nested-promise-above-callback-2/page.js → ...p/nested-promise-above-callback-2/page.js
@@ -9,8 +9,8 @@ function Wrapper() {
   return <Inner />
 }
 
-function Inner() {
-  foo()
+async function Inner() {
+  await foo()
   return null
 }
 

diff --git a/...y/nested-promise-above-callback-3/page.js → ...p/nested-promise-above-callback-3/page.js b/...y/nested-promise-above-callback-3/page.js → ...p/nested-promise-above-callback-3/page.js
@@ -9,8 +9,8 @@ function Wrapper() {
   return <Inner />
 }
 
-function Inner() {
-  foo()
+async function Inner() {
+  await foo()
   return null
 }
 

diff --git a/...y/nested-promise-above-callback-4/page.js → ...ted-promise-above-callback-4-sync/page.js b/...y/nested-promise-above-callback-4/page.js → ...ted-promise-above-callback-4-sync/page.js
@@ -13,7 +13,7 @@ function Inner() {
   return null
 }
 
-async function foo() {
+function foo() {
   unstable_after(bar())
 }
 

diff --git a/...p-dir/next-after-app-errors/react-owner-stack/app/nested-promise-above-callback-4/page.js b/...p-dir/next-after-app-errors/react-owner-stack/app/nested-promise-above-callback-4/page.js
@@ -0,0 +1,32 @@
+import { unstable_after } from 'next/server'
+
+export default function Page() {
+  return <Wrapper />
+}
+
+function Wrapper() {
+  return <Inner />
+}
+
+async function Inner() {
+  await foo()
+  return null
+}
+
+async function foo() {
+  unstable_after(bar())
+}
+
+async function bar() {
+  unstable_after(function aboveZap() {
+    return zap()
+  })
+}
+
+async function zap() {
+  throws()
+}
+
+function throws() {
+  throw new Error('kaboom')
+}
diff --git a/.../app/error-overlay/nested-promise/page.js → ...ct-owner-stack/app/nested-promise/page.js b/.../app/error-overlay/nested-promise/page.js → ...ct-owner-stack/app/nested-promise/page.js
@@ -17,7 +17,7 @@ function Inner() {
 function helper() {
   unstable_after(
     (async () => {
-      await setTimeout(500)
+      await setTimeout(0)
       nestedHelper()
     })()
   )
@@ -26,7 +26,7 @@ function helper() {
 function nestedHelper() {
   unstable_after(
     (async () => {
-      await setTimeout(500)
+      await setTimeout(0)
       throws()
     })()
   )

diff --git a/...fter-app/app/error-overlay/nested/page.js → ...rors/react-owner-stack/app/nested/page.js b/...fter-app/app/error-overlay/nested/page.js → ...rors/react-owner-stack/app/nested/page.js
@@ -16,14 +16,14 @@ function Inner() {
 
 function helper() {
   unstable_after(async function aboveNestedHelper() {
-    await setTimeout(500)
+    await setTimeout(0)
     nestedHelper()
   })
 }
 
 function nestedHelper() {
   unstable_after(async function aboveThrows() {
-    await setTimeout(500)
+    await setTimeout(0)
     throws()
   })
 }

diff --git a/test/e2e/app-dir/next-after-app-errors/react-owner-stack/app/simple-callback/page.js b/test/e2e/app-dir/next-after-app-errors/react-owner-stack/app/simple-callback/page.js
@@ -0,0 +1,26 @@
+import { unstable_after } from 'next/server'
+import { setTimeout } from 'timers/promises'
+
+export default function Page() {
+  return <Wrapper />
+}
+
+function Wrapper() {
+  return <Inner />
+}
+
+function Inner() {
+  helper()
+  return null
+}
+
+function helper() {
+  unstable_after(async () => {
+    await setTimeout(0)
+    throws()
+  })
+}
+
+function throws() {
+  throw new Error('kaboom')
+}
diff --git a/.../app/error-overlay/simple-promise/page.js → ...ct-owner-stack/app/simple-promise/page.js b/.../app/error-overlay/simple-promise/page.js → ...ct-owner-stack/app/simple-promise/page.js