verify persistent function only calls persistent functions

vercel · Sep 5, 2024 · 976dbe9 · 976dbe9
1 parent d2571a8
commit 976dbe9
Showing 1 changed file with 8 additions and 0 deletions.
diff --git a/turbopack/crates/turbo-tasks-backend/src/backend/mod.rs b/turbopack/crates/turbo-tasks-backend/src/backend/mod.rs
@@ -592,6 +592,14 @@ impl Backend for TurboTasksBackend {
         parent_task: TaskId,
         turbo_tasks: &dyn TurboTasksBackendApi<Self>,
     ) -> TaskId {
+        if !parent_task.is_transient() {
+            let parent_task_type = self.lookup_task_type(parent_task);
+            panic!(
+                "Calling transient function {} from persistent function function {} is not allowed",
+                task_type.get_name(),
+                parent_task_type.map_or_else(|| "unknown".into(), |t| t.get_name())
+            );
+        }
         if let Some(task_id) = self.task_cache.lookup_forward(&task_type) {
             self.connect_child(parent_task, task_id, turbo_tasks);
             return task_id;