update todos

vercel · Oct 14, 2024 · 5464098 · 5464098
1 parent 4b5ed19
commit 5464098
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 5 deletions.
diff --git a/packages/next/src/export/routes/app-page.ts b/packages/next/src/export/routes/app-page.ts
@@ -54,7 +54,6 @@ export async function exportAppPage(
   isDynamicError: boolean,
   fileWriter: FileWriter
 ): Promise<ExportRouteResult> {
-  // TODO(after): should we use the onClose from MockedResponse?
   const afterRunner = new AfterRunner()
 
   const renderOpts: RenderOpts = {
@@ -84,7 +83,9 @@ export async function exportAppPage(
 
     const html = result.toUnchunkedString()
 
-    await afterRunner.executeAfter() // TODO(after): thrown errors?
+    // TODO(after): if we abort a prerender because of an error in an after-callback
+    // we should probably communicate that better (and not log the error twice)
+    await afterRunner.executeAfter()
 
     const { metadata } = result
     const {

diff --git a/packages/next/src/export/routes/app-route.ts b/packages/next/src/export/routes/app-route.ts
@@ -54,7 +54,6 @@ export async function exportAppRoute(
     signalFromNodeResponse(res)
   )
 
-  // TODO(after): should we use the onClose from MockedResponse?
   const afterRunner = new AfterRunner()
 
   // Create the context for the handler. This contains the params from
@@ -116,7 +115,9 @@ export async function exportAppRoute(
 
     const blob = await response.blob()
 
-    await afterRunner.executeAfter() // TODO(after): thrown errors?
+    // TODO(after): if we abort a prerender because of an error in an after-callback
+    // we should probably communicate that better (and not log the error twice)
+    await afterRunner.executeAfter()
 
     const revalidate =
       typeof (context.renderOpts as any).collectedRevalidate === 'undefined' ||

diff --git a/packages/next/src/server/after/after-context.ts b/packages/next/src/server/after/after-context.ts
@@ -87,7 +87,7 @@ export class AfterContext {
         await callback()
       } catch (err) {
         // TODO(after): this is fine for now, but will need better intergration with our error reporting.
-        // TODO: should we log this if we have a onTaskError callback?
+        // TODO(after): should we log this if we have a onTaskError callback?
         console.error(
           'An error occurred in a function passed to `unstable_after()`:',
           err