Skip to content

Commit

Permalink
fixed bug #362, also set chunks names (#363)
Browse files Browse the repository at this point in the history
* fixed bug #362, also set chunks names

* set simple solution for minChunks

* revert in favor of #310
  • Loading branch information
mr47 authored and arunoda committed Dec 15, 2016
1 parent ab14770 commit 45e36fd
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 2 deletions.
2 changes: 1 addition & 1 deletion server/build/webpack.js
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ export default async function createCompiler (dir, { hotReload = false, dev = fa
new webpack.optimize.CommonsChunkPlugin({
name: 'commons',
filename: 'commons.js',
minChunks: pages.length
minChunks: Math.max(2, pages.length)
})
]

Expand Down
1 change: 0 additions & 1 deletion server/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,6 @@ export default class Server {
const p = join(__dirname, '..', 'client', ...(params.path || []))
await this.serveStatic(req, res, p)
})

this.router.get('/static/:path+', async (req, res, params) => {
const p = join(this.dir, 'static', ...(params.path || []))
await this.serveStatic(req, res, p)
Expand Down

0 comments on commit 45e36fd

Please sign in to comment.