Fix cursor position

vercel · Dec 3, 2024 · 3d9ed04 · 3d9ed04
1 parent 356055b
commit 3d9ed04
Show file tree

Hide file tree

Showing 5 changed files with 16 additions and 12 deletions.
diff --git a/packages/next/src/client/components/react-dev-overlay/server/middleware-turbopack.ts b/packages/next/src/client/components/react-dev-overlay/server/middleware-turbopack.ts
@@ -229,8 +229,13 @@ async function nativeTraceSource(
             ?.replace('__WEBPACK_DEFAULT_EXPORT__', 'default')
             ?.replace('__webpack_exports__.', '') ||
           '<unknown>',
-        column: originalPosition.column ?? 0,
-        file: originalPosition.source,
+        column: (originalPosition.column ?? 0) + 1,
+        file: originalPosition.source?.startsWith('file://')
+          ? path.relative(
+              process.cwd(),
+              url.fileURLToPath(originalPosition.source)
+            )
+          : originalPosition.source,
         lineNumber: originalPosition.line ?? 0,
         // TODO: c&p from async createOriginalStackFrame but why not frame.arguments?
         arguments: [],

diff --git a/test/development/app-dir/dynamic-error-trace/index.test.ts b/test/development/app-dir/dynamic-error-trace/index.test.ts
@@ -41,16 +41,15 @@ describe('app dir - dynamic error trace', () => {
     )
 
     const codeframe = await getRedboxSource(browser)
-    // TODO(NDX-115): column for "^"" marker is inconsistent between native, Webpack, and Turbopack
     expect(codeframe).toEqual(
       process.env.TURBOPACK
         ? outdent`
-            app/lib.js (4:12) @ Foo
+            app/lib.js (4:13) @ Foo
             
               2 |
               3 | export function Foo() {
             > 4 |   useHeaders()
-                |            ^
+                |             ^
               5 |   return 'foo'
               6 | }
               7 |

diff --git a/test/development/app-dir/owner-stack-invalid-element-type/invalid-element-type.test.ts b/test/development/app-dir/owner-stack-invalid-element-type/invalid-element-type.test.ts
@@ -66,12 +66,12 @@ const isOwnerStackEnabled =
       if (process.env.TURBOPACK) {
         expect(stackFramesContent).toMatchInlineSnapshot(`""`)
         expect(source).toMatchInlineSnapshot(`
-          "app/rsc/page.js (5:10) @ Inner
+          "app/rsc/page.js (5:11) @ Inner
 
             3 | // Intermediate component for testing owner stack
             4 | function Inner() {
           > 5 |   return <Foo />
-              |          ^
+              |           ^
             6 | }
             7 |
             8 | export default function Page() {"

diff --git a/...lopment/app-dir/owner-stack-invalid-element-type/owner-stack-invalid-element-type.test.ts b/...lopment/app-dir/owner-stack-invalid-element-type/owner-stack-invalid-element-type.test.ts
@@ -70,15 +70,15 @@ const isOwnerStackEnabled =
 
       if (process.env.TURBOPACK) {
         expect(stackFramesContent).toMatchInlineSnapshot(
-          `"at Page (app/rsc/page.js (11:7))"`
+          `"at Page (app/rsc/page.js (11:8))"`
         )
         expect(source).toMatchInlineSnapshot(`
-          "app/rsc/page.js (5:10) @ Inner
+          "app/rsc/page.js (5:11) @ Inner
 
             3 | // Intermediate component for testing owner stack
             4 | function Inner() {
           > 5 |   return <Foo />
-              |          ^
+              |           ^
             6 | }
             7 |
             8 | export default function Page() {"

diff --git a/...ent/app-dir/owner-stack-react-missing-key-prop/owner-stack-react-missing-key-prop.test.ts b/...ent/app-dir/owner-stack-react-missing-key-prop/owner-stack-react-missing-key-prop.test.ts
@@ -29,12 +29,12 @@ const isOwnerStackEnabled =
           `"at Page (app/rsc/page.tsx (6:13))"`
         )
         expect(source).toMatchInlineSnapshot(`
-        "app/rsc/page.tsx (7:9) @ <anonymous>
+        "app/rsc/page.tsx (7:10) @ <anonymous>
 
            5 |     <div>
            6 |       {list.map((item, index) => (
         >  7 |         <span>{item}</span>
-             |         ^
+             |          ^
            8 |       ))}
            9 |     </div>
           10 |   )"