Add additional test for named regexes

vercel · Jan 27, 2020 · 30533e9 · 30533e9
1 parent 2c26320
commit 30533e9
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 0 deletions.
diff --git a/test/integration/custom-routes/next.config.js b/test/integration/custom-routes/next.config.js
@@ -151,6 +151,11 @@ module.exports = {
           destination: '/another/:0/:test/:1',
           permanent: false,
         },
+        {
+          source: '/docs/:first(integrations|now-cli)/v2:second(.*)',
+          destination: '/:first*/:second*',
+          permanent: false,
+        },
       ]
     },
 

diff --git a/test/integration/custom-routes/test/index.test.js b/test/integration/custom-routes/test/index.test.js
@@ -290,6 +290,20 @@ const runTests = (isDev = false) => {
     expect(pathname).toBe('/another/first/second/hello/world')
   })
 
+  it('should handle named regex parameters with multi-match successfully', async () => {
+    const res = await fetchViaHTTP(
+      appPort,
+      '/docs/integrations/v2-some/thing',
+      undefined,
+      {
+        redirect: 'manual',
+      }
+    )
+    const { pathname } = url.parse(res.headers.get('location') || '')
+    expect(res.status).toBe(307)
+    expect(pathname).toBe('/integrations/-some/thing')
+  })
+
   if (!isDev) {
     it('should output routes-manifest successfully', async () => {
       const manifest = await fs.readJSON(
@@ -411,6 +425,14 @@ const runTests = (isDev = false) => {
             source: '/unnamed-params/nested/(.*?)/:test/(.*)',
             statusCode: 307,
           },
+          {
+            destination: '/:first*/:second*',
+            regex: normalizeRegEx(
+              '^\\/docs(?:\\/(integrations|now-cli))\\/v2(.*)$'
+            ),
+            source: '/docs/:first(integrations|now-cli)/v2:second(.*)',
+            statusCode: 307,
+          },
         ],
         headers: [
           {