Export the other cookie types

vercel · Nov 22, 2022 · 2b36be3 · 2b36be3
1 parent 5f310ed
commit 2b36be3
Show file tree

Hide file tree

Showing 4 changed files with 37 additions and 4 deletions.
diff --git a/packages/next/server.d.ts b/packages/next/server.d.ts
@@ -12,3 +12,8 @@ export { userAgentFromString } from 'next/dist/server/web/spec-extension/user-ag
 export { userAgent } from 'next/dist/server/web/spec-extension/user-agent'
 export { URLPattern } from 'next/dist/compiled/@edge-runtime/primitives/url'
 export { RequestCookies } from 'next/dist/server/web/spec-extension/cookies/request-cookies'
+export { ResponseCookies } from 'next/dist/server/web/spec-extension/cookies/response-cookies'
+export {
+  RequestCookie,
+  ResponseCookie,
+} from 'next/dist/server/web/spec-extension/cookies/types'
diff --git a/packages/next/server.js b/packages/next/server.js
@@ -10,6 +10,9 @@ const serverExports = {
   RequestCookies:
     require('next/dist/server/web/spec-extension/cookies/request-cookies')
       .RequestCookies,
+  ResponseCookies:
+    require('next/dist/server/web/spec-extension/cookies/response-cookies')
+      .ResponseCookies,
 }
 
 if (typeof URLPattern !== 'undefined') {
@@ -28,3 +31,4 @@ exports.userAgentFromString = serverExports.userAgentFromString
 exports.userAgent = serverExports.userAgent
 exports.URLPattern = serverExports.URLPattern
 exports.RequestCookies = serverExports.RequestCookies
+exports.ResponseCookies = serverExports.ResponseCookies
diff --git a/test/integration/typescript/pages/api/edge.ts b/test/integration/typescript/pages/api/edge.ts
@@ -1,4 +1,11 @@
-import { NextRequest, RequestCookies } from 'next/server'
+import {
+  NextRequest,
+  NextResponse,
+  RequestCookie,
+  RequestCookies,
+  ResponseCookie,
+  ResponseCookies,
+} from 'next/server'
 
 export const config = {
   runtime: 'experimental-edge',
@@ -8,7 +15,22 @@ const AsyncApiEndpoint = async (req: NextRequest) => {
   // Test cookies type
   const cookies: RequestCookies = req.cookies
 
-  return new Response(cookies instanceof RequestCookies ? 'ok' : 'error')
+  const res = new NextResponse()
+
+  const resCookies: ResponseCookies = res.cookies
+
+  const cookie: RequestCookie = { name: 'foo', value: 'bar' }
+
+  req.cookies.set(cookie)
+
+  const resCookie: ResponseCookie = { name: 'foo', value: 'bar' }
+
+  res.cookies.set(resCookie)
+
+  return NextResponse.json({
+    RequestCookies: cookies instanceof RequestCookies,
+    ResponseCookies: resCookies instanceof ResponseCookies,
+  })
 }
 
 export default AsyncApiEndpoint
diff --git a/test/integration/typescript/test/index.test.js b/test/integration/typescript/test/index.test.js
@@ -65,8 +65,10 @@ describe('TypeScript Features', () => {
     })
 
     it('should handle edge api route and req cookies', async () => {
-      const data = await renderViaHTTP(appPort, '/api/edge')
-      expect(data).toEqual('ok')
+      const data = JSON.parse(await renderViaHTTP(appPort, '/api/edge'))
+
+      expect(data.RequestCookies).toBe(true)
+      expect(data.ResponseCookies).toBe(true)
     })
 
     // old behavior: