Fix handling finished response (#889)

* allows to not return props if response is already finished on getInitialProps * check res.finished after getInitialProps call of Document
vercel · Jan 26, 2017 · 0b3db91 · 0b3db91
1 parent 386c960
commit 0b3db91
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/lib/utils.js b/lib/utils.js
@@ -46,7 +46,7 @@ export async function loadGetInitialProps (Component, ctx) {
   if (!Component.getInitialProps) return {}
 
   const props = await Component.getInitialProps(ctx)
-  if (!props) {
+  if (!props && (!ctx.res || !ctx.res.finished)) {
     const compName = Component.displayName || Component.name
     const message = `"${compName}.getInitialProps()" should resolve to an object. But found "${props}" instead.`
     throw new Error(message)

diff --git a/server/render.js b/server/render.js
@@ -83,6 +83,8 @@ async function doRender (req, res, pathname, query, {
 
   const docProps = await loadGetInitialProps(Document, { ...ctx, renderPage })
 
+  if (res.finished) return
+
   const doc = createElement(Document, {
     __NEXT_DATA__: {
       component,