ncc internal typescript build bug workaround #445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
styfle
approved these changes
Jul 2, 2019
|
Seems like the tests didn't like it |
guybedford
force-pushed
the
typescript-workaround
branch
from
59c6f5e to
88be8d0
Compare
Codecov Report
@@ Coverage Diff @@
## master #445 +/- ##
=======================================
Coverage 74.68% 74.68%
=======================================
Files 13 13
Lines 395 395
=======================================
Hits 295 295
Misses 100 100Continue to review full report at Codecov.
|
|
Looks good, ready to merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides a workaround for #435 by using the previous TypeScript build.
Hopefully we can get a proper bug fix in soon as well to avoid this workaround.