Fix regression where CLI doesnt build index.js #414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
styfle
approved these changes
Jun 3, 2019
Codecov Report
@@ Coverage Diff @@
## master #414 +/- ##
=======================================
Coverage 73.65% 73.65%
=======================================
Files 13 13
Lines 391 391
=======================================
Hits 288 288
Misses 103 103
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just noticed this regression on the CLI from the multi-entry work - when running
ncc build xit was outputtingdist/x.jsinstead ofdist/index.js.The fix is to ensure we pass a string input from the CLI when there is a single file, and an array when there is more than one.