Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Externals mapping support #402

Merged
merged 2 commits into from
May 24, 2019
Merged

Externals mapping support #402

merged 2 commits into from
May 24, 2019

Conversation

guybedford
Copy link
Contributor

This adds support for an object form in externals to support remapping the externals value in the target environment.

This is a necessary feature for the next.js support.

@guybedford guybedford requested a review from styfle as a code owner May 22, 2019 10:38
@codecov-io
Copy link

codecov-io commented May 22, 2019

Codecov Report

Merging #402 into master will increase coverage by 1.19%.
The diff coverage is 87.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #402      +/-   ##
==========================================
+ Coverage   73.29%   74.49%   +1.19%     
==========================================
  Files          14       14              
  Lines         397      396       -1     
==========================================
+ Hits          291      295       +4     
+ Misses        106      101       -5
Impacted Files Coverage Δ
src/@@notfound.js 0% <0%> (ø) ⬆️
src/index.js 83.53% <100%> (+0.41%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0b0911...9c71345. Read the comment docs.

@guybedford guybedford merged commit 31448a0 into master May 24, 2019
@guybedford guybedford deleted the externals-map branch May 24, 2019 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants