Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optional chaining #534

Closed
webbertakken opened this issue Apr 27, 2020 · 3 comments
Closed

Optional chaining #534

webbertakken opened this issue Apr 27, 2020 · 3 comments
Labels
enhancement New feature or request

Comments

@webbertakken
Copy link

Nextjs is already supporting optional chaining. I was hoping we could get it here too.

I would be willing to contribute if you can confirm this feature is wanted, in which case please do let me know where to start.
@styfle
Copy link
Member

styfle commented May 18, 2020

Absolutely we would accept a PR with optional chaining.

I believe the blocker here is upstream acornjs/acorn#891

@styfle styfle added the enhancement New feature or request label May 18, 2020
@Nabellaleen
Copy link

For information, it seems to works with TS, while targeting es2019 in tsconfig.json

peps1 added a commit to peps1/srrup that referenced this issue Aug 5, 2020
@peps1
for ncc to handle optional chaining... 🤷vercel/ncc#534
cbbd059
@styfle
Copy link
Member

styfle commented Sep 9, 2021

This has been implemented, thanks!

@styfle styfle closed this as completed Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@styfle @Nabellaleen @webbertakken