Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix linux tab margin #442

Merged
merged 2 commits into from
Jul 26, 2016
Merged

Fix linux tab margin #442

merged 2 commits into from
Jul 26, 2016

Conversation

c0b41
Copy link
Contributor

@c0b41 c0b41 commented Jul 26, 2016

@albinekb
Copy link
Contributor

This will probably need to happen on windows too, http://electron.atom.io/docs/api/browser-window/

Maybe it's better to only set titleBarStyle on macOS and then use that to decide the margin?
https://github.com/zeit/hyperterm/blob/master/app/index.js#L52

@rauchg
Copy link
Member

rauchg commented Jul 26, 2016

It should be 76 if it's explicitly darwin as opposed to non-linux

@rauchg rauchg merged commit 83d7db3 into vercel:master Jul 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants