Add tray icon and set single instance mode to improve startup time on Windows #3324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a tray icon with exit option and new window option Always Preloads a hidden window (without rpc handler and terminal session) When a new window needs to be opened, the preloaded window will have its rpc and terminal session attached and brough to front
|
🙏 @phungtuanhoang1996 awesome work! I will review this ASAP. My first thought was: is this a common behavior on Windows to not quit an app? Maybe we should add an opt-out option? |
|
I did include an option to really quit the app in the context menu from the tray icon. |
|
Oh... I didn't see the systray context menu. Sorry. For the option, let see if user are complaining about this. |
chabou
approved these changes
Dec 16, 2018
chabou
changed the title
chabou
changed the title
|
We are really honored to merge your first open-source contribution 🙏 |
chabou
added a commit
to chabou/hyper
that referenced
this pull request
Dec 22, 2018
… time on Windows (vercel#3324)" This reverts commit f324a67.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my attempt to address ther slow startup time on Windows, and also my first attempt to contribute to an open-source project (because I really like Hyper)
Please feel free to review and comment on what can be improve / went wrong. Thanks! 😄
Changed hyper to be running single instance mode on windows
Added a tray icon with exit option and new window option
Always Preloads a hidden window (without rpc handler and terminal session)
When a new window needs to be opened, the preloaded window will have its rpc and terminal session attached and brough to front