Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default keymaps reference to documentation #2185

Merged
merged 1 commit into from
Sep 8, 2017

Conversation

arojunior
Copy link
Contributor

closes #2167

This PR just add a table referencing the default keymaps for Windows, Linux and MacOS. It was not in the documentation.

Copy link
Contributor

@chabou chabou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR.

@@ -698,6 +698,17 @@ <h2 id="keymaps"><a href="#keymaps">Keymaps</a></h2>

};</code></pre>

<p>Default keymaps: </p>

<table class="keymaps">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why table has this keymaps class? 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're welcome.

I was following the same pattern of the other tables as api and config with that styles and etc, but at the end I decided just put the links, so now actually there's no reason to. I can update the commit with no class if you want to.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes please

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

@chabou chabou merged commit 6d68278 into vercel:master Sep 8, 2017
@chabou
Copy link
Contributor

chabou commented Sep 8, 2017

🙏 Thank you so much for your help

chabou added a commit that referenced this pull request Sep 10, 2017
* master:
  Add default keymaps reference to documentation (#2185)
  Add category option under linux key in root package.json (#2184)
  Add vscode debug config, update readme (#2181)
  Get default config options when not specified in user config (#2126)
  Fix session cleaning (#2176)
  Delete .DS_Store file (#2171)
h93xV2 pushed a commit to h93xV2/hyper that referenced this pull request Sep 11, 2017
spncrgr pushed a commit to spncrgr/hyper that referenced this pull request Sep 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants