-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add default keymaps reference to documentation #2185
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this PR.
website/index.html
Outdated
@@ -698,6 +698,17 @@ <h2 id="keymaps"><a href="#keymaps">Keymaps</a></h2> | |||
|
|||
};</code></pre> | |||
|
|||
<p>Default keymaps: </p> | |||
|
|||
<table class="keymaps"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why table has this keymaps
class? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're welcome.
I was following the same pattern of the other tables as api and config with that styles and etc, but at the end I decided just put the links, so now actually there's no reason to. I can update the commit with no class if you want to.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes please
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done.
🙏 Thank you so much for your help |
* master: Add default keymaps reference to documentation (#2185) Add category option under linux key in root package.json (#2184) Add vscode debug config, update readme (#2181) Get default config options when not specified in user config (#2126) Fix session cleaning (#2176) Delete .DS_Store file (#2171)
closes #2167
This PR just add a table referencing the default keymaps for Windows, Linux and MacOS. It was not in the documentation.