Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for xterm 3.2.0? #2751

Closed
2 tasks done
saamalik opened this issue Mar 11, 2018 · 3 comments · Fixed by #2768
Closed
2 tasks done

Support for xterm 3.2.0? #2751

saamalik opened this issue Mar 11, 2018 · 3 comments · Fixed by #2768
Labels
help wanted Contributions wanted towards the issue 🎨 Type: Enhancement Issue or PR is an enhancement request/proposal for Hyper
Milestone
2.0.0

Comments

@saamalik
Copy link
Contributor

  • I am on the latest Hyper.app version
  • I have searched the issues of this repo and believe that this is not a duplicate

Hi all -- xterm released the latest version xterm 3.2.0 a few days ago. Any plans to support this latest version?

I also attempted to change xterm dependency to 3.2.0 but looks like the scrolling behavior has changed.
@saamalik
Copy link
Contributor Author

I found the xterm commit which broke the scroll behavior in Hyper: xtermjs/xterm.js@dc759a9.

Verified by reverting the commit. Anyway, the proper solution is to probably figure out how to incorporate scrollbar changes into Hyper.

/cc @chabou

@saamalik
Copy link
Contributor Author

argg -- looks like this was already reported by @chabou at #2686.

@chabou
Copy link
Contributor

chabou commented Mar 11, 2018

We need to support this latest version.
Indeed we had some layout problems due to CSS changes with xterm v3.1.0.
But we had some pane width issue too.

We really need to tackle this ASAP

@chabou chabou reopened this Mar 11, 2018
@chabou chabou added this to the 2.0.0 milestone Mar 11, 2018
@chabou chabou added 🎨 Type: Enhancement Issue or PR is an enhancement request/proposal for Hyper help wanted Contributions wanted towards the issue labels Mar 11, 2018
@chabou chabou mentioned this issue Mar 17, 2018
Merged
chabou added a commit that referenced this issue Mar 17, 2018
@chabou
Integrate xterm v3.2 (#2768)
4297103 
* Add xterm3.2

Fixes #2751
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Contributions wanted towards the issue 🎨 Type: Enhancement Issue or PR is an enhancement request/proposal for Hyper
Projects
None yet
Milestone
2.0.0
Development

Successfully merging a pull request may close this issue.

Integrate xterm v3.2 chabou/hyper
2 participants
@saamalik @chabou