Fixes issue with next/dynamic when running next version > 12.0.3 #618
Conversation
|
Someone is attempting to deploy a commit to the Vercel Solutions Team on Vercel. A member of the Team first needs to authorize it. |
|
This pull request is being automatically deployed with Vercel (learn more). commerce-local – ./🔍 Inspect: https://vercel.com/vercel-solutions-vtest314/commerce-local/5EQ8JMcwLTwcq8LtkCGras8Wt5c2 |
MikeDupree
changed the title
|
Updated to use prop spreading as suggested by @ancaemcken |
| @@ -31,22 +31,31 @@ const dynamicProps = { | |||
|
|
|||
| const SignUpView = dynamic( | |||
| () => import('@components/auth/SignUpView'), | |||
| dynamicProps | |||
| { | |||
| ...dynamicProps | |||
There was a problem hiding this comment.
For the cases that we don't need to extend the object can you leave it like before? Or does it have any problem with it?
There was a problem hiding this comment.
dynamic() needs an object literal, the way it was before was causing the issue
…cel#618) Co-authored-by: mdupree <[email protected]>
Fixes issue seen with next/dynamic when running yarn install due to problems with newer versions of next
Regarding issue #614
vercel/next.js#31683