Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#157): error when rendering Nuxt component #160

Merged
merged 1 commit into from
Nov 19, 2024
Merged

Conversation

feugy
Copy link
Member

@feugy feugy commented Nov 19, 2024

🖖 What's in there?

A fix for #157.

🤺 How to test?

It's actually not possible to reproduce the issue with the example app. Possibly because of intra-monorepo depdencies.
To reproduce the issue:

  1. change dependency in apps/nuxt/package.json: `"@vercel/analytics": "1.4.0"``
  2. pnpm -F nuxt dev, then browse to the app: you'll see the error.

🔬Notes to reviewers

Since this is an urgent bug fix, I've reverted @emspishak's changes from 1.5.0-canary.1, but we have #158 in the pipe for covering this new feature as well.

@feugy feugy requested a review from a team November 19, 2024 17:01
Copy link

vercel bot commented Nov 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
analytics-astro ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 19, 2024 5:04pm
analytics-next15 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 19, 2024 5:04pm
analytics-nextjs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 19, 2024 5:04pm
analytics-nuxt ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 19, 2024 5:04pm
analytics-remix ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 19, 2024 5:04pm
analytics-sveltekit ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 19, 2024 5:04pm
analytics-vue ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 19, 2024 5:04pm

@feugy feugy merged commit 56ebed2 into main Nov 19, 2024
13 checks passed
@feugy feugy deleted the fix/nuxt-component branch November 19, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants