Add support for CWT Claims & Type in Protected Headers #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: steve lasker <[email protected]>
SteveLasker
requested review from
henkbirkholz,
qmuntal,
roywill,
setrofim,
shizhMSFT,
SimonFrost-Arm,
thomas-fossati and
yogeshbdeshpande
as code owners
OR13
approved these changes
Jul 12, 2024
setrofim
approved these changes
Jul 15, 2024
headers.go
Outdated
| @@ -471,6 +497,25 @@ func validateHeaderParameters(h map[any]any, protected bool) error { | |||
| if err := ensureCritical(value, h); err != nil { | |||
| return fmt.Errorf("header parameter: crit: %w", err) | |||
| } | |||
| case HeaderLabelType: | |||
| is_tstr := canTstr(value) | |||
There was a problem hiding this comment.
I've changed this and the isAlg for consistency
Signed-off-by: steve lasker <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to DCO complications, this is a recreation of #183
Please see all comments in 183, including PR/LGTMs
fixes #173
fixes #184