-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for CWT Claims & Type in Protected Headers #183
Closed
Closed
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
bc4610a
add initial test
OR13 25991e9
fix test
OR13 203b417
add basic test for cwt
OR13 adc1599
Update cwt_test.go
yogeshbdeshpande a379d94
Update cwt_test.go
OR13 1a0f2e1
Update Readme for latest release (#182)
SteveLasker c7cee92
add typ and validation
OR13 026b364
add initial test
OR13 a0aff97
fix test
OR13 65cbebc
add basic test for cwt
OR13 9c30e67
Update cwt_test.go
yogeshbdeshpande 51788e9
Update cwt_test.go
OR13 acc2fef
Update Readme for latest release (#182)
SteveLasker 53cc3cc
add typ and validation
OR13 479710f
Update cwt.go
SteveLasker c9f2ab1
Update cwt_test.go
SteveLasker 4c57853
Update cwt_test.go
OR13 1980457
Merge
OR13 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
package cose | ||
|
||
// https://www.iana.org/assignments/cwt/cwt.xhtml#claims-registry | ||
const ( | ||
CWTClaimIssuer int64 = 1 | ||
CWTClaimSubject int64 = 2 | ||
CWTClaimAudience int64 = 3 | ||
CWTClaimExpirationTime int64 = 4 | ||
CWTClaimNotBefore int64 = 5 | ||
CWTClaimIssuedAt int64 = 6 | ||
CWTClaimCWTID int64 = 7 | ||
CWTClaimConfirmation int64 = 8 | ||
CWTClaimScope int64 = 9 | ||
|
||
// TODO: the rest upon request | ||
) | ||
|
||
// CWTClaims contains parameters that are to be cryptographically | ||
// protected. | ||
type CWTClaims map[any]any |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,82 @@ | ||
package cose_test | ||
|
||
import ( | ||
"crypto/ecdsa" | ||
"crypto/elliptic" | ||
"crypto/rand" | ||
"fmt" | ||
|
||
"github.com/veraison/go-cose" | ||
) | ||
|
||
// This example demonstrates signing and verifying COSE_Sign1 signatures. | ||
func ExampleCWTMessage() { | ||
// create message to be signed | ||
msgToSign := cose.NewSign1Message() | ||
msgToSign.Payload = []byte("hello world") | ||
msgToSign.Headers.Protected.SetAlgorithm(cose.AlgorithmES512) | ||
|
||
msgToSign.Headers.Protected.SetType("application/cwt") | ||
claims := cose.CWTClaims{ | ||
cose.CWTClaimIssuer: "issuer.example", | ||
cose.CWTClaimSubject: "subject.example", | ||
} | ||
msgToSign.Headers.Protected.SetCWTClaims(claims) | ||
|
||
msgToSign.Headers.Unprotected[cose.HeaderLabelKeyID] = []byte("1") | ||
|
||
// create a signer | ||
privateKey, err := ecdsa.GenerateKey(elliptic.P521(), rand.Reader) | ||
if err != nil { | ||
panic(err) | ||
} | ||
signer, err := cose.NewSigner(cose.AlgorithmES512, privateKey) | ||
if err != nil { | ||
panic(err) | ||
} | ||
|
||
// sign message | ||
err = msgToSign.Sign(rand.Reader, nil, signer) | ||
if err != nil { | ||
panic(err) | ||
} | ||
sig, err := msgToSign.MarshalCBOR() | ||
// uncomment to review EDN | ||
// coseSign1Diagnostic, err := cbor.Diagnose(sig) | ||
// fmt.Println(coseSign1Diagnostic) | ||
OR13 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
if err != nil { | ||
panic(err) | ||
} | ||
fmt.Println("message signed") | ||
|
||
// create a verifier from a trusted public key | ||
publicKey := privateKey.Public() | ||
verifier, err := cose.NewVerifier(cose.AlgorithmES512, publicKey) | ||
if err != nil { | ||
panic(err) | ||
} | ||
|
||
// verify message | ||
var msgToVerify cose.Sign1Message | ||
err = msgToVerify.UnmarshalCBOR(sig) | ||
if err != nil { | ||
panic(err) | ||
} | ||
err = msgToVerify.Verify(nil, verifier) | ||
if err != nil { | ||
panic(err) | ||
} | ||
fmt.Println("message verified") | ||
|
||
// tamper the message and verification should fail | ||
msgToVerify.Payload = []byte("foobar") | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. for this test, it might be better to tamper with the protected header. |
||
err = msgToVerify.Verify(nil, verifier) | ||
if err != cose.ErrVerification { | ||
panic(err) | ||
} | ||
fmt.Println("verification error as expected") | ||
// Output: | ||
// message signed | ||
// message verified | ||
// verification error as expected | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it is smart to add the whole registry in the first PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on the above, it looks like we have the minimal code needed to proceed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should add what is bare minimum required, and then extend it when a new point needs to be registered!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I have probably missed the right conversations, but I am not sure I get what the strategy is. There are 10's of claims already registered. What is the criterion for promoting them from the CWT Claims registry to
const
s in thecose
package?I think we should explicitly document how to add new claims here.