Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy cocli documentation #99

Merged
merged 10 commits into from
Jan 17, 2024
Merged

Tidy cocli documentation #99

merged 10 commits into from
Jan 17, 2024

Conversation

yogeshbdeshpande
Copy link
Contributor

@yogeshbdeshpande yogeshbdeshpande commented Dec 14, 2023

Refactor cocli documentation for better expression. Fixes #102

@yogeshbdeshpande yogeshbdeshpande changed the title Tidy documentation Tidy cocli documentation Dec 14, 2023
@thomas-fossati
Copy link
Contributor

I don't believe that splitting the existing content into separate files will effectively address the issues identified by @hannestschofenig.

The points he made were:

  1. Increase the veracity of the command line examples by using the template files from the data/templates folder
  2. Give the reader an early overview of the CoRIM flow and explain how each cocli sub-command fits into the flow
  3. Link the template files from the examples so that the user can inspect them with a single click

which this PR doesn't seem to address.

@yogeshbdeshpande
Copy link
Contributor Author

3. m the examples so that the user can inspect them with a single

  1. This is just a start: It does not make sense to have a long README.md like this. Users get lost:

  2. Yes for your point 1, I am going to make a follow up PR. It will use the actual templates from the Templates folder, in the README examples!

  3. Linking the Template files in the examples, yes, we can do it!

This is a start and believe it is a good start!

@yogeshbdeshpande
Copy link
Contributor Author

2. overview of the CoRIM flow and explain how each cocli sub-command fits i

  • Also I observed Hannes could not locate some of the cots documentation

@yogeshbdeshpande
Copy link
Contributor Author

2. Give the reader an early overview of the CoRIM flow and explain how each cocli sub-command fits into the flow

Also on 2. above, is helped by splitting README.md as Reader gets much more quicker access to overall flow daigram, which sets the real context!

@thomas-fossati
Copy link
Contributor

It does not make sense to have a long README.md like this. Users get lost:

No one lamented on the length of the file. I think you are solving a non-issue here. The main concerns were:

  • the relative positioning of the material, with the "overall picture" stashed at the bottom rather than near the top

  • the lack of veracity of the examples

See also #102

  1. Yes for your point 1, I am going to make a follow up PR. It will use the actual templates from the Templates folder, in the README examples!
  2. Linking the Template files in the examples, yes, we can do it!

Why not address it now rather than doing a split that no one asked?

@yogeshbdeshpande
Copy link
Contributor Author

It does not make sense to have a long README.md like this. Users get lost:

No one lamented on the length of the file. I think you are solving a non-issue here. The main concerns were:

  • the relative positioning of the material, with the "overall picture" stashed at the bottom rather than near the top
  • the lack of veracity of the examples

See also #102

  1. Yes for your point 1, I am going to make a follow up PR. It will use the actual templates from the Templates folder, in the README examples!
  2. Linking the Template files in the examples, yes, we can do it!

Why not address it now rather than doing a split that no one asked?

Yes, I am making the change to replace the fictitious examples with real examples, as part of the same PR:

However, at the same time long README's are not preferred. They can be problematic, risk reader losing context!

@yogeshbdeshpande
Copy link
Contributor Author

@thomas-fossati Not sure whether you noticed the point mentioned in #89

I am also trying to address this issue, using the same PR

@thomas-fossati
Copy link
Contributor

thomas-fossati commented Dec 14, 2023

@thomas-fossati Not sure whether you noticed the point mentioned in #89

I am also trying to address this issue, using the same PR

Yes. I'd have expected that this PR would move up that diagram, make the command line examples replayable using existing templates, and link those templates at the point where they are used.

Instead, it mainly consisted of fixing something that no one had complained about 😄

@yogeshbdeshpande
Copy link
Contributor Author

@thomas-fossati Not sure whether you noticed the point mentioned in #89
I am also trying to address this issue, using the same PR

Yes. I'd have expected that this PR would move up that diagram, make the command line examples replayable using existing templates, and link those templates at the point where they are used.

Instead, it mainly consisted of fixing something that no one had complained about 😄

Yes, the diagram is much closer now, as the README.md is nicely into seperate sub-sections, per context. A user does not has to browse all the way down to view the picture.

We can move this right at the top, only risk I feel is displaying something without much context!

Fixes #102

Signed-off-by: Yogesh Deshpande <[email protected]>
cocli/COMID.md Outdated Show resolved Hide resolved
cocli/COMID.md Outdated Show resolved Hide resolved
cocli/COMID.md Outdated Show resolved Hide resolved
cocli/COMID.md Outdated Show resolved Hide resolved
cocli/README.md Outdated Show resolved Hide resolved
cocli/README.md Outdated Show resolved Hide resolved
Signed-off-by: Yogesh Deshpande <[email protected]>
Signed-off-by: Yogesh Deshpande <[email protected]>
Signed-off-by: Yogesh Deshpande <[email protected]>
Signed-off-by: Yogesh Deshpande <[email protected]>
Signed-off-by: Yogesh Deshpande <[email protected]>
Signed-off-by: Yogesh Deshpande <[email protected]>
Copy link
Contributor

@thomas-fossati thomas-fossati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks very much for incorporating my comments!

@yogeshbdeshpande yogeshbdeshpande merged commit 32821f1 into main Jan 17, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restructuring the documentation of CoCli
2 participants