-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tidy cocli
documentation
#99
Conversation
20df70b
to
be59f61
Compare
I don't believe that splitting the existing content into separate files will effectively address the issues identified by @hannestschofenig. The points he made were:
which this PR doesn't seem to address. |
This is a start and believe it is a good start! |
|
Also on 2. above, is helped by splitting README.md as Reader gets much more quicker access to overall flow daigram, which sets the real context! |
No one lamented on the length of the file. I think you are solving a non-issue here. The main concerns were:
See also #102
Why not address it now rather than doing a split that no one asked? |
Yes, I am making the change to replace the fictitious examples with However, at the same time |
@thomas-fossati Not sure whether you noticed the point mentioned in #89 I am also trying to address this issue, using the same PR |
Yes. I'd have expected that this PR would move up that diagram, make the command line examples replayable using existing templates, and link those templates at the point where they are used. Instead, it mainly consisted of fixing something that no one had complained about 😄 |
Yes, the diagram is much closer now, as the README.md is nicely into seperate sub-sections, per context. A user does not has to browse all the way down to view the picture. We can move this right at the top, only risk I feel is |
Fixes #102 Signed-off-by: Yogesh Deshpande <[email protected]>
dde4536
to
d12f940
Compare
Signed-off-by: Yogesh Deshpande <[email protected]>
Signed-off-by: Yogesh Deshpande <[email protected]>
Signed-off-by: Yogesh Deshpande <[email protected]>
Signed-off-by: Yogesh Deshpande <[email protected]>
Signed-off-by: Yogesh Deshpande <[email protected]>
Signed-off-by: Yogesh Deshpande <[email protected]>
Signed-off-by: Yogesh Deshpande <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks very much for incorporating my comments!
Refactor cocli documentation for better expression. Fixes #102