Downgrade Diplomat gem to ~> 2.0.5 #38
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nogazr
force-pushed
the
downgrade-diplomat-to-2.0.5
branch
from
195d23d to
8311785
Compare
nogazr
commented
Jan 12, 2023
| @@ -21,7 +21,7 @@ def service(key, scope: :all, options: {}, meta: {}) | |||
| end | |||
|
|
|||
| # Execute a prepared query | |||
| def query(name_or_id, options: nil) | |||
| def query(name_or_id, options: {}) | |||
There was a problem hiding this comment.
I modified this to keep this options variable consistent as the other Consul methods (service and key), they are also having as default an empty hash
nogazr
force-pushed
the
test-consul-query-method
branch
3 times, most recently
from
28b88b3 to
3d7fb20
Compare
|
This fix is included in this PR #39 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes