Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Normalize local resource addresses to localhost #21

Merged
merged 1 commit into from
Jun 27, 2019
Merged

Normalize local resource addresses to localhost #21

merged 1 commit into from
Jun 27, 2019

Conversation

aharpervc
Copy link
Contributor

@aharpervc aharpervc commented Jun 25, 2019 •
edited
Loading

  • 0.0.0.0 & 127.0.0.1 -> localhost
  • 0.0.0.0 is not connectable on Windows

@aharpervc
Copy link
Contributor Author

travisssssssssssssssssss

@aharpervc
Normalize local resource addresses to localhost
9cd0fa7 
- this also fixes not being able to connect on Windows
@aharpervc aharpervc force-pushed the normalize-test-configuration branch from b0dba94 to 9cd0fa7 Compare June 26, 2019 19:41
@aharpervc aharpervc changed the base branch from master to circleci June 26, 2019 19:42
@aharpervc aharpervc self-assigned this Jun 26, 2019
@aharpervc
Copy link
Contributor Author

aharpervc commented Jun 26, 2019 •
edited
Loading

solved the travis build failure by switching to circleci: https://circleci.com/gh/veracross/consult/7

@aharpervc aharpervc marked this pull request as ready for review June 26, 2019 19:43
mmartell37
mmartell37 approved these changes Jun 27, 2019
View reviewed changes
Copy link
Contributor

@mmartell37 mmartell37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 I forgot the silly names we added to the tests...

@sixfeetover sixfeetover merged commit d245ece into circleci Jun 27, 2019
aharpervc added a commit that referenced this pull request Jun 27, 2019
@aharpervc
Normalize local resource addresses to localhost (#21)
02e743f 
- this also fixes not being able to connect on Windows
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sixfeetover sixfeetover sixfeetover approved these changes

@dylan-azucena dylan-azucena dylan-azucena approved these changes

@mmartell37 mmartell37 mmartell37 approved these changes

Assignees

@aharpervc aharpervc

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aharpervc @sixfeetover @dylan-azucena @mmartell37