Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated get_findings to work with csv string list #89

Merged
merged 4 commits into from
Oct 25, 2024

Conversation

AaronButler-Veracode
Copy link
Contributor

Findings get_findings method was not working with a csv style list of scan types.

Copy link
Member

@tjarrettveracode tjarrettveracode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @AaronButler-Veracode -- for this change I’d prefer to introduce a separate class for the CWE related endpoints since they’re not strictly related to Findings. Something like:

class CWE():
        def get(self, cwe_Id):
                 return #api call here

Let me know if this makes sense. Thanks.

@tjarrettveracode
Copy link
Member

Also we’ll need to update the documentation for a new method.

@tjarrettveracode tjarrettveracode merged commit b437b16 into veracode:main Oct 25, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants